Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install Bar Chart plugin by default #5088

Closed
akhenry opened this issue Apr 19, 2022 · 6 comments · Fixed by #5163
Closed

Do not install Bar Chart plugin by default #5088

akhenry opened this issue Apr 19, 2022 · 6 comments · Fixed by #5163
Labels
type:maintenance tests, chores, or project maintenance
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Apr 19, 2022

Summary

The Bar Chart plugin is being installed by default right now. This plugin is still somewhat experimental and in a state of flux, so it should be opt-in for now.

@akhenry akhenry added type:maintenance tests, chores, or project maintenance Target:2.0.3 labels Apr 19, 2022
@unlikelyzero
Copy link
Collaborator

@akhenry will this need to be installed in viper-openmct and other downstream projects?

@ozyx
Copy link
Member

ozyx commented May 5, 2022

Testing

Is not installed by default in production mode

  1. Build OpenMCT from source
  2. Start OpenMCT in production mode (e.g.: import openmct.js, call openmct.start()). Do not explicitly install the Chart plugin.
  3. Notice that the Chart plugin is not installed by default (domain objects such as "Bar Graph" do not appear in the Create menu).

Is installed by default in development mode

  1. Start OpenMCT in development mode (e.g.: npm start workflow)
  2. Notice that the Chart plugin is installed by default ("Bar Graph" appears in the Create menu)

@unlikelyzero
Copy link
Collaborator

@ozyx if someone had an object created with this before the plugin was removed, how would open MCT behave on 'upgrade'?

@ozyx
Copy link
Member

ozyx commented May 5, 2022

@ozyx if someone had an object created with this before the plugin was removed, how would open MCT behave on 'upgrade'?

Good question.

It looks like the current behavior is that any domain objects with missing or unregistered types are still displayed in the object tree, but as objects of UNKNOWN_TYPE:

e.g.:
image

Clicking on them routes properly but does not display anything other than the object name in the main view pane.

There doesn't seem to be any notification raised that MCT has encountered objects with unregistered types.

@akhenry
Copy link
Contributor Author

akhenry commented May 20, 2022

Users will just have to install the plugin to restore the previous behavior, I think it's ok.

akhenry added a commit that referenced this issue May 24, 2022
* Do not install Chart plugin by default (#5088)

* Install Chart plugin in development mode (#5088)

Co-authored-by: Andrew Henry <akhenry@gmail.com>
@khalidadil
Copy link
Contributor

I'm not seeing the bar chart under the create menu on testathon. Verified fixed - testathon 06/09/22

@unlikelyzero unlikelyzero added this to the Target:2.0.5 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants