Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset Gauge limits are being handled as 0 #5139

Closed
1 of 5 tasks
charlesh88 opened this issue Apr 28, 2022 · 8 comments · Fixed by #5156
Closed
1 of 5 tasks

Unset Gauge limits are being handled as 0 #5139

charlesh88 opened this issue Apr 28, 2022 · 8 comments · Fixed by #5156

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Apr 28, 2022

Summary

If a low and/or high limit is not set for a Gauge, it is treated by the Gauge as if it was actually set to 0. Instead, that limit should not be displayed at all. The fix here is to use a v-if="lowLimit !== empty instead of the current null check.

Steps to Reproduce

  1. Edit props:

image

  1. Observe: limits are displayed properly.

image

  1. Edit properties to remove limit definitions

image

  1. Observe: limits should not be displayed, but are.

image

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Testing Notes

  1. Create a Gauge view or edit existing.
  2. Repeat steps 1 - 4 in 'Steps to Reproduce' above.
  3. Verify that limits are not displayed, and the Gauge looks similar to this:
    image
@charlesh88
Copy link
Contributor Author

A fix for this caused a regression that made the limits not display at all. Work being done in the gauge-fixes branch by @charlesh88 will fix this.

@michaelrogers
Copy link
Contributor

During testathon 06/15/2022, a regression on gauge low/high limits was observed. If a user sets a range low and a range high value, it is not displayed in any of the gauge types
Screen Shot 2022-06-15 at 5 34 14 PM
Screen Shot 2022-06-15 at 5 34 23 PM
.

@ozyx
Copy link
Member

ozyx commented Jun 23, 2022

Testathon 6/23/22:

Verified that after removing limits, the min and max values are displayed instead.

Still need to verify this, misunderstood directions 😔

Caveat:

  • Ran into issues with properties persisting after changing them. Had to focus a different object and come back to the Gauge in order for the property changes to persist. Seems likely a separate issue?

@alizenguyen
Copy link
Contributor

Testathon 6/27/22:

Still see what Jesse is seeing about the property change is not implemented until you move to a different object and come back.

@ozyx
Copy link
Member

ozyx commented Jun 27, 2022

Testathon 6/27/22:

Could not get Gauge limits to show up at all-- Gauge stayed completely grey with various limit values

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jun 27, 2022

General issue filed here #5398 Will reverify

@charlesh88
Copy link
Contributor Author

Testing Notes

See #5323

@davetsay
Copy link
Contributor

davetsay commented Jul 6, 2022

verified (although i had to create two gauges to compare as there is a forms mutation bug preventing exact replication steps from working)

@akhenry akhenry removed the unverified label Jul 6, 2022
@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to Needs triage in Build 6 Blockers via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Wont Fix milestone Jul 17, 2022
@unlikelyzero unlikelyzero modified the milestones: Wont Fix, Sprint:2.0.7 Jul 17, 2022
@unlikelyzero unlikelyzero moved this from To triage to Ready! in Improve Test Coverage Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs triage to Needs an automated test in Build 6 Blockers Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Build 6 Blockers
Needs an automated test
Development

Successfully merging a pull request may close this issue.

8 participants