Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery View does not discard old images when they fall out of bounds #5291

Closed
3 of 7 tasks
akhenry opened this issue Jun 6, 2022 · 3 comments · Fixed by #5351
Closed
3 of 7 tasks

Imagery View does not discard old images when they fall out of bounds #5291

akhenry opened this issue Jun 6, 2022 · 3 comments · Fixed by #5351

Comments

@akhenry
Copy link
Contributor

akhenry commented Jun 6, 2022

Summary

In real-time mode the Imagery View should discard images that are older than the configured start bounds as our other telemetry views (such as tables and plots) do.

This is probably a good opportunity to upgrade the imagery view to use TelemetryCollections, as they will handle all of the necessary bounds checks etc. and just emit events when images should be added and removed from the view.

Steps to Reproduce

  1. Open example imagery
  2. Switch to local clock in the time conductor
  3. Set the start bounds to something short (eg. 30 seconds)
  4. Wait until the oldest image is older than the configured start bound
  5. Observe that it is not removed from the filmstrip view.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?
@scottbell
Copy link
Contributor

Was able to reproduce; investigating now.

@shefalijoshi
Copy link
Contributor

Verified fixed

@ozyx
Copy link
Member

ozyx commented Jun 27, 2022

Verified -- Testathon 6/27/22

@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Jul 17, 2022
@unlikelyzero unlikelyzero added this to Needs triage in Build 6 Blockers via automation Jul 17, 2022
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jul 17, 2022
@unlikelyzero unlikelyzero added this to the Sprint:2.0.7 milestone Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs triage to Needs an automated test in Build 6 Blockers Jul 17, 2022
@unlikelyzero unlikelyzero moved this from Needs an automated test to e2e Test Added in Build 6 Blockers Jul 17, 2022
@unlikelyzero unlikelyzero moved this from To triage to Integrated in Improve Test Coverage Jul 17, 2022
@unlikelyzero unlikelyzero removed this from the Sprint:2.0.7 milestone Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Build 6 Blockers
e2e Test Added
Development

Successfully merging a pull request may close this issue.

5 participants