Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5291 imagery view does not discard old images when they fall out of bounds #5346

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jun 14, 2022

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Jun 14, 2022 that may be closed by this pull request
7 tasks
@scottbell scottbell changed the base branch from release/2.0.5 to master June 14, 2022 15:18
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #5346 (d179595) into master (84f1a61) will increase coverage by 0.05%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
+ Coverage   49.48%   49.54%   +0.05%     
==========================================
  Files         589      589              
  Lines       21563    21553      -10     
  Branches     2020     2020              
==========================================
+ Hits        10671    10678       +7     
+ Misses      10350    10332      -18     
- Partials      542      543       +1     
Impacted Files Coverage Δ
example/imagery/plugin.js 5.66% <0.00%> (-0.34%) ⬇️
src/plugins/imagery/mixins/imageryData.js 77.02% <50.00%> (+4.61%) ⬆️
...c/plugins/persistence/couch/CouchObjectProvider.js 80.78% <0.00%> (-1.18%) ⬇️
...ettingsSynchronizer/URLTimeSettingsSynchronizer.js 97.97% <0.00%> (+1.01%) ⬆️
src/ui/router/Browse.js 90.41% <0.00%> (+1.36%) ⬆️
src/plugins/tabs/components/tabs.vue 36.00% <0.00%> (+1.60%) ⬆️
src/plugins/imagery/components/ImageryTimeView.vue 78.16% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f1a61...d179595. Read the comment docs.

@scottbell scottbell closed this Jun 15, 2022
@scottbell scottbell deleted the 5291-imagery-view-does-not-discard-old-images-when-they-fall-out-of-bounds branch November 30, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants