Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc UI problems #5640

Closed
12 tasks done
charlesh88 opened this issue Aug 10, 2022 · 3 comments · Fixed by #5762
Closed
12 tasks done

Misc UI problems #5640

charlesh88 opened this issue Aug 10, 2022 · 3 comments · Fixed by #5762

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 10, 2022

  • Make Display Layout frame edit handles overlap content, not resize it.
  • Fix search progress bar display so that progress bar doesn't lay under text.
  • Dial Gauges should center in their container, not left flush.
  • Add large icon for the aggregate telemetry type.
  • Add large icon for the Telemetry Table type. Closes Grid icons are wrong #5303.
  • Fix descriptions for Telemetry Table, LAD Table and LAD Table Set.
  • Restore tree and Inspector pane's ability to collapse when dragged small enough.
  • Fix grippy icons in elements pool.
  • Fix value alignment in alphanumerics in Display Layouts.
  • Fix Locator in dialog to expand to use available space.
  • Fix styling of numeric inputs, especially in Firefox and on Linux.
  • Display Layout layout objects are erroneously using the unknown object icon because their type is not being properly defined and they end up using UNKNOWN_TYPE from TypeRegistry.js.

Misaligned alphas in Display Layout
image

Numeric inputs in Firefox
image

@charlesh88 charlesh88 self-assigned this Aug 10, 2022
charlesh88 added a commit that referenced this issue Aug 11, 2022
- Center Dial Gauge in its container.
@charlesh88
Copy link
Contributor Author

charlesh88 commented Aug 11, 2022

WIP in branch misc-ui-5640-r208

charlesh88 added a commit that referenced this issue Aug 17, 2022
- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing.
- Gauge now centers in its container instead of left flush.
- Added large bg-icon for aggregate telemetry.
charlesh88 added a commit that referenced this issue Aug 17, 2022
- Removed 'no class' single wrapper div in mct-tree.vue.
- Refinements to appearance of locator in save/edit overlay dialog.
charlesh88 added a commit that referenced this issue Aug 17, 2022
- Better styling for search in progress and 'no results' messaging.
charlesh88 added a commit that referenced this issue Aug 17, 2022
- Revised art and glyph for `icon-tabular-scrolling`.
- Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon.
- Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.
charlesh88 added a commit that referenced this issue Aug 17, 2022
- Fix descriptions for multiple view types.
charlesh88 added a commit that referenced this issue Aug 17, 2022
- Removed unused .bg-icon class.
@charlesh88
Copy link
Contributor Author

charlesh88 commented Aug 18, 2022

Testing Notes

  1. Edit a Display Layout, add a Gauge view with 'Dial' type to it.
  2. Verify that when mousing over the object's frame that a handle animates down from the frame top and sits over the object view, not vertically shrinking it. See attached image "Gauge in Display Layout" (orange arrow) for reference.
  3. Size the frame such that it is wider than tall, landscape proportions. Verify that the dial element centers in the frame. See attached image "Gauge in Display Layout" (purple arrows) for reference.
  4. Add one or more telemetry end points as alphanumerics, ideally with different character counts of values. Size their layout frames such that both the label and value are fully in view. Set the font size for one alpha different from the other. Verify that values line up vertically at the halfway point across the frame. See "Better alphas in Display Layout" below.
  5. Add drawing objects to the layout, a variety if possible. Verify that when selected, the Inspector shows an icon for the type of drawing object: box, circle, line, "A" and image icon, followed by the word "Layout Object". See "Layout drawing objects" below.
  6. After selecting a drawing object, select the Gauge and verify that it shows the correct icon in the Inspector. Also click the empty area of the layout and verify that the Display Layout icon is displayed in the Inspector.
  7. While you're doing this, verify that number inputs appear correctly in the toolbar, ideally in both Chrome and Firefox. See "Number inputs..." screenshots below.
  8. Exit editing the layout.
  9. Navigate to a folder that contains an aggregate telemetry data type. Verify that the aggregate item in the Folder's grid view displays an aggregate icon. See attached image "Aggregate Icon" (yellow arrow) for reference.
  10. Click the Create button and rollover "Telemetry Table". Verify that menu item displays the new icon art for that object type, as shown in attached image "Telemetry Table in Create menu" below.
  11. Access the edit Properties screen by creating a new object or editing an existing one. The fix in this case was to allow the locator to dynamically size itself to fit the available space; to test, change the browser window size to increase and decrease the size of the dialog and verify that the locator expands and contracts vertically to fill available space. Note that the locator has a minimum height - making the dialog very short may result in two scrollbars appearing, one in the locator and the other for the dialog contents. This is right and proper. Scroll in the locator, expand and collapse tree items. Verify that the Locator displays as expected, and all expected tree nodes can be gotten to and there are no visual issues. See "Dynamic Locator" below.
  12. Verify that number inputs appear properly across the application, especially in Firefox. Note that Chrome only shows spinners on hover or focus in the input, while Firefox always shows them. This is native browser behavior.
    • Edit a layout, add/edit a drawing object to display the X/Y/W/H number input boxes.
    • Create or edit a Timer view, examine the number inputs in the Properties dialog for the datetime.
    • Put the Time Conductor into real-time mode and click the start or end to display the number inputs in the popup bubble.
  13. Use search, and verify that the search progress bar appears vertically beneath the text "Searching..." as shown in "Search in progress" below.

Gauge in Display Layout
Screen Shot 2022-08-17 at 5 28 07 PM

Better alphas in Display Layout
Screen Shot 2022-08-18 at 6 02 04 PM

Aggregate Icon
Screen Shot 2022-08-17 at 5 41 03 PM

Telemetry Table in Create menu
Screen Shot 2022-08-17 at 5 44 35 PM

Dynamic Locator
Screen Shot 2022-08-19 at 10 10 04 AM

Number inputs in Chrome
Screen Shot 2022-08-19 at 10 44 20 AM

Number inputs in Firefox
Screen Shot 2022-08-19 at 10 44 02 AM

Search in progress
Screen Shot 2022-08-19 at 2 33 14 PM

Layout drawing objects
Screen Shot 2022-08-19 at 3 22 59 PM

charlesh88 added a commit that referenced this issue Aug 18, 2022
- Fixed bad value check that was causing panes not to collapse when dragged
(by design) to a very narrow width.
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Visual style for grippy adjusted for better clarity on some monitors.
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Normalize size of alphanumeric's labels and values in Display Layouts.
- Fix margin strategy for object label in main view.
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Fixed Locator to dynamically size itself to use available vertical space.
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Added new `l-overlay-dialog` size parameter.
- Better approach to overlay sizing to make Properties dialogs larger vertically
and fullscreen overlays more apparent to the user.
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Normalized approach to numeric inputs to fix cross-browser
inconsistency with input spinners.
- Fixed layout problem in `Datetime.vue` component due to
numeric input spinners changes.
This was referenced Aug 19, 2022
charlesh88 added a commit that referenced this issue Aug 19, 2022
- Added object types for Display Layout drawing objects.
- Code modded in `ObjectName.vue` to grab layout object cssClass from
layoutItem.type.
- Big thanks to @jvigliotta for the assist with this!
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Added object types for Display Layout drawing objects.
- Code modded in `ObjectName.vue` to grab layout object cssClass from
layoutItem.type.
- Big thanks to @jvigliotta for the assist with this!
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing.
- Gauge now centers in its container instead of left flush.
- Added large bg-icon for aggregate telemetry.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Removed 'no class' single wrapper div in mct-tree.vue.
- Refinements to appearance of locator in save/edit overlay dialog.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Better styling for search in progress and 'no results' messaging.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Revised art and glyph for `icon-tabular-scrolling`.
- Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon.
- Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Fix descriptions for multiple view types.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Removed unused .bg-icon class.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Fixed bad value check that was causing panes not to collapse when dragged
(by design) to a very narrow width.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Added new `l-overlay-dialog` size parameter.
- Better approach to overlay sizing to make Properties dialogs larger vertically
and fullscreen overlays more apparent to the user.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Normalized approach to numeric inputs to fix cross-browser
inconsistency with input spinners.
- Fixed layout problem in `Datetime.vue` component due to
numeric input spinners changes.
ozyx pushed a commit that referenced this issue Aug 23, 2022
- Added object types for Display Layout drawing objects.
- Code modded in `ObjectName.vue` to grab layout object cssClass from
layoutItem.type.
- Big thanks to @jvigliotta for the assist with this!
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing.
- Gauge now centers in its container instead of left flush.
- Added large bg-icon for aggregate telemetry.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Removed 'no class' single wrapper div in mct-tree.vue.
- Refinements to appearance of locator in save/edit overlay dialog.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Better styling for search in progress and 'no results' messaging.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Revised art and glyph for `icon-tabular-scrolling`.
- Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon.
- Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Fix descriptions for multiple view types.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Removed unused .bg-icon class.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Fixed bad value check that was causing panes not to collapse when dragged
(by design) to a very narrow width.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Visual style for grippy adjusted for better clarity on some monitors.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Normalize size of alphanumeric's labels and values in Display Layouts.
- Fix margin strategy for object label in main view.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Fixed Locator to dynamically size itself to use available vertical space.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Added new `l-overlay-dialog` size parameter.
- Better approach to overlay sizing to make Properties dialogs larger vertically
and fullscreen overlays more apparent to the user.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Normalized approach to numeric inputs to fix cross-browser
inconsistency with input spinners.
- Fixed layout problem in `Datetime.vue` component due to
numeric input spinners changes.
charlesh88 added a commit that referenced this issue Sep 14, 2022
- Added object types for Display Layout drawing objects.
- Code modded in `ObjectName.vue` to grab layout object cssClass from
layoutItem.type.
- Big thanks to @jvigliotta for the assist with this!
@charlesh88 charlesh88 mentioned this issue Sep 14, 2022
15 tasks
akhenry added a commit that referenced this issue Sep 20, 2022
* Closes #5640
- Layout frame edit handle visually tweaked, no longer resizes frame contents on hover when editing.
- Gauge now centers in its container instead of left flush.
- Added large bg-icon for aggregate telemetry.
- Removed 'no class' single wrapper div in mct-tree.vue.
- Refinements to appearance of locator in save/edit overlay dialog.
- Better styling for search in progress and 'no results' messaging.
- Revised art and glyph for `icon-tabular-scrolling`.
- Change TelemetryTableType to use icon-tabular-scrolling icon and bg-icon.
- Fix bad/erroneous descriptions for Telemetry Table, LAD Table and LAD Table Set.
- Fix descriptions for multiple view types.
- Removed unused .bg-icon class.
- Fixed bad value check that was causing panes not to collapse when dragged
(by design) to a very narrow width.
- Visual style for grippy adjusted for better clarity on some monitors.
- Normalize size of alphanumeric's labels and values in Display Layouts.
- Fix margin strategy for object label in main view.
- Fixed Locator to dynamically size itself to use available vertical space.
- Added new `l-overlay-dialog` size parameter.
- Better approach to overlay sizing to make Properties dialogs larger vertically
and fullscreen overlays more apparent to the user.
- Normalized approach to numeric inputs to fix cross-browser
inconsistency with input spinners.
- Fixed layout problem in `Datetime.vue` component due to
numeric input spinners changes.
- Added object types for Display Layout drawing objects.
- Code modded in `ObjectName.vue` to grab layout object cssClass from
layoutItem.type.
- Big thanks to @jvigliotta for the assist with this!
- update snapshots

Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov>
Co-authored-by: Andrew Henry <akhenry@gmail.com>
@shefalijoshi shefalijoshi added this to the Target:2.1.1 milestone Sep 30, 2022
@unlikelyzero unlikelyzero added needs:e2e Needs an e2e test and removed Target:2.1.1 labels Sep 30, 2022
@shefalijoshi
Copy link
Contributor

DAYUMMMMM!
Verified Fixed!

@unlikelyzero unlikelyzero added this to To triage in Improve Test Coverage via automation Sep 30, 2022
@charlesh88 charlesh88 mentioned this issue Oct 11, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants