Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProgressBar] Update progressPerc to be null, not undefined #6085

Closed
jvigliotta opened this issue Dec 28, 2022 · 1 comment · Fixed by #6953
Closed

[ProgressBar] Update progressPerc to be null, not undefined #6085

jvigliotta opened this issue Dec 28, 2022 · 1 comment · Fixed by #6953
Labels
help_wanted Help the Open MCT project! type:enhancement
Milestone

Comments

@jvigliotta
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Our ProgressBar component https://github.com/nasa/openmct/blob/master/src/ui/components/ProgressBar.vue currently uses undefined for the percentage of progress property of the model. This should most likely be null as pointed out here: #6067 (comment)

Describe the solution you'd like
Update to check for null. Update any other uses of ProgressBar in the code bass and update to pass in null.

Describe alternatives you've considered
Leaving as is, but this is less intuitive to what it actually represents.

@jvigliotta jvigliotta added type:enhancement help_wanted Help the Open MCT project! labels Dec 28, 2022
@ozyx ozyx changed the title [ProgressBarr] Update progressPerc to be null, not undefined [ProgressBar] Update progressPerc to be null, not undefined Dec 28, 2022
@jvigliotta
Copy link
Contributor Author

@ozyx what if I wanted that extrra "r"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help_wanted Help the Open MCT project! type:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants