Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar null not undefined #6953

Merged
merged 8 commits into from Aug 29, 2023
Merged

ProgressBar null not undefined #6953

merged 8 commits into from Aug 29, 2023

Conversation

depperm
Copy link
Contributor

@depperm depperm commented Aug 17, 2023

Closes #6085

Describe your changes:

Change parameter from undefined to null

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 17, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/29/2023 11:20:39pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 1fdef86

Started: 08/29/2023 11:14:08pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
3.08% (2) 2 / 65 runs
failed over last 7 days
50.77% (33) 33 / 65 runs
flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 63 runs
failed over last 7 days
46.03% (29) 29 / 63 runs
flaked over last 7 days

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
3.13% (2) 2 / 64 runs
failed over last 7 days
12.50% (8) 8 / 64 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 96 runs
failed over last 7 days
52.08% (50) 50 / 96 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #6953 (1fdef86) into master (ca06a6a) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #6953      +/-   ##
==========================================
+ Coverage   48.30%   48.31%   +0.01%     
==========================================
  Files         643      643              
  Lines       25730    25730              
  Branches     2512     2512              
==========================================
+ Hits        12429    12432       +3     
+ Misses      12819    12817       -2     
+ Partials      482      481       -1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (-0.03%) ⬇️ Carriedforward from a9a9b2c
e2e-stable 57.18% <ø> (-0.03%) ⬇️
unit 38.69% <50.00%> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/api/notifications/NotificationAPI.js 98.83% <ø> (ø)
src/api/overlays/OverlayAPI.js 86.66% <ø> (ø)
src/plugins/formActions/CreateAction.js 92.06% <ø> (ø)
src/plugins/notebook/components/Notebook.vue 19.10% <0.00%> (ø)
src/plugins/plot/Plot.vue 0.00% <ø> (ø)
src/ui/components/ProgressBar.vue 100.00% <ø> (ø)
src/ui/layout/BrowseBar.vue 23.40% <ø> (ø)
src/ui/layout/search/SearchResultsDropDown.vue 5.88% <ø> (ø)
src/ui/layout/status-bar/NotificationBanner.vue 50.00% <ø> (+5.17%) ⬆️
src/plugins/telemetryTable/components/table.vue 41.35% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca06a6a...1fdef86. Read the comment docs.

@ozyx ozyx added the source:community Community contribution or request label Aug 17, 2023
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 18, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! There are a couple more spots we need to fix:

Here and here

After fixing those, please double-check with a regex search and make sure we catch all of these and that there are no other explicit checks against undefined otherwise we could introduce errors.

@ozyx ozyx self-requested a review August 24, 2023 17:48
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 28, 2023
@ozyx ozyx enabled auto-merge (squash) August 28, 2023 22:59
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Aug 29, 2023
@ozyx ozyx merged commit b87459d into nasa:master Aug 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ProgressBar] Update progressPerc to be null, not undefined
3 participants