Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use anchor tags with href for navigation #61

Open
larkin opened this issue Aug 5, 2015 · 2 comments
Open

Use anchor tags with href for navigation #61

larkin opened this issue Aug 5, 2015 · 2 comments

Comments

@larkin
Copy link
Contributor

larkin commented Aug 5, 2015

We should use standard browser navigation via anchor tags with href attributes instead of ng-click directives that tie directly into the navigation service.

This allows us to reuse standard anchor styles (cursor changes, etc), and is more in line with how browser navigation works on the open internet.

@VWoeltjen
Copy link
Contributor

Moving comment over from #289:

We could remove navigation as a concern from the information model and just handle it in the display layer (e.g. as links); I agree this would be much more in line with normal functionality. This makes initiating these interactions in other ways a little difficult however (e.g. navigating to an object upon its creation), and runs a risk of becoming inflexible (reusing that code on the backend, for instance.) Think we'd end up wanting to express these changes as actions anyway for that purpose; possibly add an optional url property to actions allowing the display layer to represent these as simple links (in lieu of invoking perform)?

@larkin
Copy link
Contributor Author

larkin commented Nov 12, 2015

Navigation isn't a back-end concern, not even sure what navigating means in that context.

Left a comment in #69 for more discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants