Compass rose isn't being transformed properly

[charlesh88]

Summary

For cameras other than the nav cam, toggling the compass rose from FOV "up" to north "up" doesn't properly transform the equipment (spacecraft/rover) body SVG element properly.

Initially loaded FOV "up" for aftcam:

Having toggled the rose to north "up":

Note erroneous position of the body element.

Expected vs Current Behavior

The equipment body element should be rotated in registration with FOV element.

Solution

The FOV indicator and rose ticks (green and yellow arrows) are rotated on toggle which is correct, but the equipment inner __body element is also being rotated on toggle - this is wrong. That element should only be transformed for cases where the camera rotates with respect to the body, like a gimbaled camera.

Instead, all of cr-vrover should rotate with the FOV. The fix here therefore (maybe?) is:

1. Move cr-vrover into the c-cr__cam-fov element, and rename that for clarity. Continue to rotate that element as current.
2. Remove the rotation on cr-vrover__body that is firing in response to compass toggling; instead, make sure that element is only transformed in the case of a gimbaled camera.

Steps to Reproduce

1. navigate to a navcam image endpoint
2. see that the equipment body is oriented properly
3. see that the camera is oriented properly in relation to the equipment
4. click on the compass rose to lock north up on the rose
5. see that the entire compass rose rotates correctly and equipment and camera are still in relation to each other
6. repeat steps with a hazcam
7. repeat steps with an aftcam

Environment

• Open MCT Version: 2.1.6-SNAPSHOT
• Deployment Type: /testathon
• OS:
• Browser:

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug with no functional impact?
• Does this block the execution of e2e tests?
• Does this have an impact on Performance?

Additional Information

[davetsay]

@charlesh88 , let me know when you need help with the Vue wiring.

[akhenry]

Not fixed.

Reproduction steps:

1. Navigate to Hazcam back left
2. Set conductor bounds to 2023-11-25 14:09:19.931Z - 2023-11-25 14:39:34.931Z
3. In the thumbnails, click back and forth between the two images (sometimes it happened with the first image, sometimes the second)
4. Observe that in the compass rose the rover is translated to the east and appears detached from the camera.

eg.

[akhenry]

@khalidadil to test

[shefalijoshi]

Seeing this error: No sure if it's related to this fix or if it needs a new issue:

[khalidadil]

I'm seeing some weirdness here. These are both the Navcam_right_image, clicking between 2 images:

[akhenry]

@khalidadil I was confused by this as well. It might actually be legit. If the Navcam is looking over its rear left and right "shoulders". From looking at the other images, the rover body is not being modeled in this sim run.

[khalidadil]

ah, got it! I think I'm also seeing something else, where the rover body jumps around after clicking an image. It doesn't happen very often, and it doesn't seem to be consistently reproducible.

[akhenry]

@khalidadil Confirmed that the PTU pan value was like -160, -170 degrees. So I think it was looking over its shoulder when those images were taken.