Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks load much slower than they used to #6459

Closed
7 tasks
akhenry opened this issue Mar 16, 2023 · 4 comments
Closed
7 tasks

Notebooks load much slower than they used to #6459

akhenry opened this issue Mar 16, 2023 · 4 comments
Labels
performance impacts or improves performance severity:critical type:bug
Milestone

Comments

@akhenry
Copy link
Contributor

akhenry commented Mar 16, 2023

Summary

Notebooks appear to show no entries for a period while loading, which can give users the false impression that their entries have been lost. This appears to be due the UI blocking while tags are fetched. There is no need to block entries from loading while tags are fetched, the tags should be fetched in parallel and "layered" on when availabe.

Expected vs Current Behavior

Notebook entries should display as soon as available and not block until tags are fetched.

Steps to Reproduce

  1. Load a notebook with some entries
  2. Observe that the notebook loads but appears to be empty (ie. no entries) for several seconds until the entries eventually appear.

Environment

  • Open MCT Version: 2.2.5
  • Deployment Type: MMOC

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

@scottbell
Copy link
Contributor

Perhaps something slow in pulling tags from Couch?

@unlikelyzero unlikelyzero added the performance impacts or improves performance label Apr 13, 2023
@unlikelyzero unlikelyzero removed this from the Target: 2.2.2 milestone Apr 13, 2023
@akhenry akhenry changed the title PLACEHOLDER Notebooks load much slower than they used to Notebooks load much slower than they used to Aug 2, 2023
@akhenry
Copy link
Contributor Author

akhenry commented Aug 2, 2023

This appears to be fixed for unknown reasons (possibly the Vue 3 refactor). Closing to retest.

@akhenry
Copy link
Contributor Author

akhenry commented Aug 2, 2023

Testing instructions

  1. Follow the reproduction steps in the issue
  2. Confirm that Notebook entries appear immediately when the notebook loads, and that tags are loaded in later.

@akhenry akhenry added this to the Target:3.0.0 milestone Aug 2, 2023
@akhenry akhenry closed this as completed Aug 2, 2023
@akhenry akhenry changed the title Notebooks load much slower than they used to Notebooks load much slower than they used to be Aug 2, 2023
@akhenry akhenry changed the title Notebooks load much slower than they used to be Notebooks load much slower than they used to Aug 2, 2023
@ozyx
Copy link
Member

ozyx commented Aug 2, 2023

Verified fixed Testathon 8/2/23

@ozyx ozyx removed the unverified label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance impacts or improves performance severity:critical type:bug
Projects
None yet
Development

No branches or pull requests

4 participants