Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font styling is lost when url property set on condition widget #6614

Closed
7 tasks
davetsay opened this issue Apr 21, 2023 · 3 comments · Fixed by #6625
Closed
7 tasks

font styling is lost when url property set on condition widget #6614

davetsay opened this issue Apr 21, 2023 · 3 comments · Fixed by #6625
Labels
type:bug
Milestone
Target:2.2.3

Comments

@davetsay
Copy link
Contributor

Summary

When the url property of a condition widget is used, the font styling is not being displayed properly. The other styling such as background, text, and border color does display properly. The Font size and styling properties are still retained on the object, but they aren't displayed.

Expected vs Current Behavior

Font styling should be displayed.

Steps to Reproduce

  1. create a condition widget
  2. in edit mode, set font size and font style
  3. save widget
  4. right-click widget in tree and select the edit properties context action
  5. add a url and save
  6. observe style is not displayed.

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser:

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information
@davetsay davetsay self-assigned this Apr 22, 2023
@davetsay davetsay mentioned this issue Apr 25, 2023
Merged
15 tasks
@charlesh88 charlesh88 self-assigned this Apr 25, 2023
charlesh88 added a commit that referenced this issue Apr 26, 2023
@charlesh88
Closes #6614
fe1bbfe 
- CSS fixes for revised widget approach.
@charlesh88
Copy link
Contributor

CSS and markup changes pushed to the branch.

Screen Shot 2023-04-26 at 11 06 48 AM

@jvigliotta jvigliotta added this to the Target:2.2.3 milestone Apr 28, 2023
jvigliotta pushed a commit that referenced this issue Apr 28, 2023
@davetsay @charlesh88
Retain styling on condition widgets when adding or removing a url (#6625
6f2b20e 
)

* fix spelling error
* apply changes after dynamic component updates
* remove * listener
* react to url change
* es6 mode
* fix html structure
* Closes #6614
- CSS fixes for revised widget approach.
* include url prop for vue component reactivity
* disable a tag overriding font color
* provide a reactive object for component reactivity

Co-authored-by: Charles Hacskaylo <charlesh88@gmail.com>
@rukmini-bose
Copy link
Contributor

Verified Testathon 5/8/23

@michaelrogers
Copy link
Contributor

Fix verified during testathon on 05/08/2023. Styling is maintained when setting and after clearing the URL property.

This was referenced Jun 10, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 10, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 28, 2023
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 7, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 14, 2023
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
Target:2.2.3
Development

Successfully merging a pull request may close this issue.

Retain styling on condition widgets when adding or removing a url nasa/openmct
6 participants
@charlesh88 @davetsay @michaelrogers @jvigliotta @unlikelyzero @rukmini-bose