Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing number of redundant requests made to search provider on tag added to an immutable object annotation #6689

Closed
3 of 7 tasks
ozyx opened this issue May 23, 2023 · 2 comments · Fixed by #6690
Closed
3 of 7 tasks

Comments

@ozyx
Copy link
Member

ozyx commented May 23, 2023

Summary

On adding a tag to an annotation of an immutable object such as a YAMCS telemetry plot, I'm seeing an increasing number of redundant requests made to the provider.

Expected vs Current Behavior

Expected:

  • at most 2 - 4 requests made to providers (CouchDB) upon adding a tag to an annotation
    Current:
  • an increasing number of requests made depending on how many annotations you've looked at so far

Steps to Reproduce

  1. Start Open MCT with YAMCS quickstart
  2. Navigate to yamcs telemetry, make a few annotations on the plot and add some tags
  3. Refresh the page and open the network tab in devtools. Set it to filter Fetch/XHR only
  4. Click on an existing annotation and add a tag. Observe there are only 2 _find requests being made
  5. Click on a bunch of the other existing annotations
  6. Create a new annotation and add a tag
  7. Observe an increased number of _find requests being made in the inspector

Environment

  • Open MCT Version: 2.2.3
  • Deployment Type: openmct-yamcs quickstart
  • OS: MacOS
  • Browser: Chrome (any)

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

Screen.Recording.2023-05-23.at.10.26.47.AM.mov
@ozyx ozyx added the type:bug label May 23, 2023
@ozyx ozyx added this to the Target:2.2.4 milestone May 23, 2023
@ozyx ozyx self-assigned this May 23, 2023
@scottbell
Copy link
Contributor

yikes! nice catch @ozyx

@shefalijoshi
Copy link
Contributor

Verified Fixed. When you navigate away from an object with annotations, subsequent views do not trigger annotation queries for tags on that object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants