Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unlisten to annotation event beforeDestroy #6690

Merged
merged 3 commits into from
May 24, 2023
Merged

fix: unlisten to annotation event beforeDestroy #6690

merged 3 commits into from
May 24, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented May 23, 2023

Closes #6689

Describe your changes:

Stops listeners from stacking up when clicking through to view multiple annotations.

TODO: CouchDB / YAMCS quickstart regression test

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:2.2.4 milestone May 23, 2023
@ozyx ozyx requested a review from scottbell May 23, 2023 18:09
@deploysentinel
Copy link

deploysentinel bot commented May 23, 2023

Current Playwright Test Results Summary

✅ 12 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/24/2023 09:29:06am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 0097a85

Started: 05/24/2023 09:26:13am UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 22 runs
failed over last 7 days
36.36% (8) 8 / 22 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #6690 (c659fe9) into master (356c90c) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6690      +/-   ##
==========================================
- Coverage   54.06%   54.05%   -0.02%     
==========================================
  Files         623      623              
  Lines       24565    24566       +1     
  Branches     2456     2456              
==========================================
- Hits        13282    13278       -4     
- Misses      10626    10628       +2     
- Partials      657      660       +3     
Flag Coverage Δ *Carryforward flag
e2e-full 31.24% <ø> (ø) Carriedforward from 1dd4a4b
e2e-stable 55.29% <ø> (ø)
unit 48.88% <0.00%> (-0.06%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ctorViews/annotations/AnnotationsInspectorView.vue 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356c90c...c659fe9. Read the comment docs.

Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix @ozyx

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label May 24, 2023
@scottbell scottbell enabled auto-merge (squash) May 24, 2023 09:26
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 24, 2023
@scottbell scottbell merged commit fea6838 into master May 24, 2023
14 of 22 checks passed
@scottbell scottbell deleted the mct6689 branch May 24, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increasing number of redundant requests made to search provider on tag added to an immutable object annotation
2 participants