Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling certain Plot Series options throws errors and doesn't work #6867

Closed
3 of 7 tasks
ozyx opened this issue Aug 1, 2023 · 4 comments · Fixed by #6868
Closed
3 of 7 tasks

Toggling certain Plot Series options throws errors and doesn't work #6867

ozyx opened this issue Aug 1, 2023 · 4 comments · Fixed by #6868

Comments

@ozyx
Copy link
Member

ozyx commented Aug 1, 2023

Summary

Toggling Alarm Markers, Markers, or changing the value of the Marker style dropdown will throw errors. As a result, these options do not work.

Expected vs Current Behavior

There should be no errors thrown and markers / alarm markers should be able to be toggled and the marker style should be able to change. The settings should persist on save.

Steps to Reproduce

  1. Create an Overlay Plot
  2. Drag some telemetry into it (or SWG)
  3. Edit
  4. In the plot series options, toggle markers, alarm markers, change marker style dropdown
  5. Notice errors and the alarm markers / markers / marker styles are not updated

Environment

  • Open MCT Version: 3.0.0-SNAPSHOT
  • Deployment Type: testathon / local
  • OS: MacOS
  • Browser: Chrome

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?
  • Does this block the execution of e2e tests?
  • Does this have an impact on Performance?

Additional Information

image

@ozyx
Copy link
Member Author

ozyx commented Aug 1, 2023

Testing Instructions

  1. Create an Overlay Plot
  2. Add some telemetry with limits to it (or SWG, preferably test both)
  3. Edit
  4. In the Plot Series options, activate and deactivate limits for different series
  5. Verify they turn on and off
  6. Save, navigate away, navigate back
  7. Verify the setting persists
  8. Activate and deactivate Alarm Markers
  9. Verify they turn on and off
  10. Save, navigate away, navigate back
  11. Verify the setting persists
  12. Change the marker style
  13. Save, hover over the plot and verify it has changed
  14. Toggling Markers on and off doesn't actually do anything due to this issue, but toggle them and make sure no errors are thrown.

@akhenry
Copy link
Contributor

akhenry commented Aug 1, 2023

Verified fixed.

@akhenry akhenry removed the unverified label Aug 1, 2023
@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 08/01/23

@rukmini-bose
Copy link
Contributor

Verified Fixed Testathon 8/1/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment