Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggling markers, alarm markers, marker style + update Vue.extend() usage to Vue 3 #6868

Merged
merged 3 commits into from Aug 1, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Aug 1, 2023

Closes #6823
Closes #6867

Describe your changes:

Our seriesElements and seriesLimits are stored in a WeakMap which is keyed on an object which has become reactive in Vue 3, and thus wrapped in a Proxy. As such, lookups with the Proxy-wrapped version of this object return undefined. The solution is to unwrap the Proxy using toRaw() before accessing the map.

I have also removed our usage of Vue.extend() and replaced it with our same mount pattern for creating limitLines and limitLabels.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:3.0.0 milestone Aug 1, 2023
@deploysentinel
Copy link

deploysentinel bot commented Aug 1, 2023

Current Playwright Test Results Summary

✅ 130 Passing - ❌ 1 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/01/2023 09:14:00pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: fdfba13

Started: 08/01/2023 09:08:49pm UTC

❌ Failures

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 2Retry 1Initial Attempt
Error: Timed out 5000ms waiting for expect(received).toBeVisible()...
Timed out 5000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for getByText('2021-12-30 01:11:00.000Z').first()
  - waiting for getByText('2021-12-30 01:11:00.000Z').first()

17.58% (16) 16 / 91 runs
failed over last 7 days
15.38% (14) 14 / 91 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
10% (10) 10 / 100 runs
failed over last 7 days
38% (38) 38 / 100 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/01/2023 09:14:00pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: fdfba13

Started: 08/01/2023 06:12:18pm UTC

⚠️ Flakes

📄   functional/tree.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Main Tree Creating a child object on one tab and expanding its parent on the other shows the correct composition @couchdb @2p
Retry 1Initial Attempt
0% (0) 0 / 49 runs
failed over last 7 days
12.24% (6) 6 / 49 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@akhenry akhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test, otherwise LGTM. Investigating...

@akhenry akhenry merged commit 95e6860 into master Aug 1, 2023
11 of 17 checks passed
@akhenry akhenry deleted the mct6823 branch August 1, 2023 21:08
ozyx added a commit that referenced this pull request Aug 1, 2023
…e + update `Vue.extend()` usage to Vue 3

* fix: update to `defineComponent` from `Vue.extend()`
* fix: unwrap Proxy arg before WeakMap.get()
* refactor: `defineComponent` not needed here
akhenry pushed a commit that referenced this pull request Aug 1, 2023
…e + update `Vue.extend()` usage to Vue 3 (#6873)

* fix: update to `defineComponent` from `Vue.extend()`
* fix: unwrap Proxy arg before WeakMap.get()
* refactor: `defineComponent` not needed here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants