Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery, Annotations] Do not show local controls when annotation gesture is active #6994

Closed
charlesh88 opened this issue Aug 25, 2023 · 5 comments · Fixed by #7028
Closed
Assignees
Milestone

Comments

@charlesh88
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Imagery and plots now allow the user to drag and mark areas in their views when holding down a key combo, in order to apply annotation tags to part of an image or selected data points in a plot. However, local controls get in the way when doing so.
Screen Shot 2023-08-25 at 11 05 16 AM

Describe the solution you'd like
Only show local controls in an annotatable view if the user is not pressing down the keyboard combo that triggers drawing an annotation selection area.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@scottbell
Copy link
Contributor

To test:

  • Create some Example Imagery
  • Click Option+Shift drag on the image to create an annotation
  • Ensure while dragging image controls are hidden
  • Ensure post drag image controls are visible again

@charlesh88
Copy link
Contributor Author

Tracking in VOMCT repo as 413.

@rukmini-bose
Copy link
Contributor

Verified Testathon 10/3/2023

@shefalijoshi
Copy link
Contributor

This sort of worked for me. After adding the annotation, if it's behind imagery controls, selecting the annotation was a bit annoying.

@ozyx
Copy link
Member

ozyx commented Oct 3, 2023

Verified fixed Testathon 10/3/2023

@ozyx ozyx removed the unverified label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants