Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide image controls when tagging, and hide compass HUD by default #7028

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Sep 1, 2023

Closes #6994 #7012

Describe your changes:

  • Hide image controls when operator is tagging images
  • Hide the compass HUD by default. Now enabled by adding option showCompassHUD to imagery plugin.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #7028 (03970e0) into master (c3b5e4e) will decrease coverage by 0.43%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master    #7028      +/-   ##
==========================================
- Coverage   55.60%   55.18%   -0.43%     
==========================================
  Files         649      649              
  Lines       26054    26060       +6     
  Branches     2547     2547              
==========================================
- Hits        14487    14380     -107     
- Misses      10868    10987     +119     
+ Partials      699      693       -6     
Flag Coverage Δ *Carryforward flag
e2e-full 41.91% <ø> (-0.21%) ⬇️ Carriedforward from 735263b
e2e-stable 57.22% <ø> (-0.12%) ⬇️
unit 48.61% <18.18%> (-0.53%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
src/plugins/imagery/ImageryView.js 100.00% <ø> (ø)
src/plugins/imagery/components/Compass/Compass.vue 70.00% <ø> (ø)
...c/plugins/imagery/components/AnnotationsCanvas.vue 2.61% <0.00%> (-0.06%) ⬇️
src/plugins/imagery/components/ImageryView.vue 41.73% <28.57%> (-0.25%) ⬇️

... and 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b5e4e...03970e0. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Sep 1, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/28/2023 03:58:10am UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 03970e0

Started: 09/28/2023 03:55:54am UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 140 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/28/2023 03:58:10am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 03970e0

Started: 09/27/2023 10:08:12pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
8.97% (7) 7 / 78 runs
failed over last 7 days
26.92% (21) 21 / 78 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 78 runs
failed over last 7 days
55.13% (43) 43 / 78 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0.90% (1) 1 / 111 run
failed over last 7 days
55.86% (62) 62 / 111 runs
flaked over last 7 days

View Detailed Build Results


@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 1, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 1, 2023
@scottbell scottbell linked an issue Sep 1, 2023 that may be closed by this pull request
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@scottbell scottbell requested review from jvigliotta and removed request for charlesh88 and ozyx September 5, 2023 08:01
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 6, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 6, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 6, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 6, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 6, 2023
@shefalijoshi shefalijoshi removed the request for review from jvigliotta September 6, 2023 20:43
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 18, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 20, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 20, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 21, 2023
@ozyx ozyx added this to the Target:3.1.0 milestone Sep 22, 2023
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the showCompasHUD prop that's passed into Compass.vue

@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 25, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 25, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 26, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 26, 2023
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2023
@scottbell scottbell enabled auto-merge (squash) September 28, 2023 03:52
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 28, 2023
@scottbell scottbell merged commit ab0e2d2 into master Sep 28, 2023
15 checks passed
@scottbell scottbell deleted the 6994-imagery-annotations-do-not-show-local-controls-when-annotation-gesture-is-active branch September 28, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants