Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imagery] Allow imagery compass "HUD" element to be disabled #7012

Closed
charlesh88 opened this issue Aug 28, 2023 · 4 comments · Fixed by #7028
Closed

[Imagery] Allow imagery compass "HUD" element to be disabled #7012

charlesh88 opened this issue Aug 28, 2023 · 4 comments · Fixed by #7028
Assignees
Milestone

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Aug 28, 2023

Is your feature request related to a problem? Please describe.
The imagery compass "HUD" element at the top of the screen visually interferes with a coordinate grid.

Screen Shot 2023-08-28 at 2 09 29 PM

Describe the solution you'd like
Hide the HUD by default, and allow a deployment to configure the HUD to be displayed if desired.

@scottbell
Copy link
Contributor

Adding new option showCompassHUD that needs to be set to true to enable the compass HUD.

@scottbell
Copy link
Contributor

scottbell commented Sep 1, 2023

To test:

  • Create Example Imagery
  • Ensure Compass HUD in image is hidden (e.g., no "N", "S", "E", "W", "NE", etc.)
  • Configure Imagery plugin with the option showCompassHUD set to true and ensure Compass HUD reappears in your Example Imagery.

@scottbell scottbell self-assigned this Sep 1, 2023
@scottbell scottbell linked a pull request Sep 1, 2023 that will close this issue
15 tasks
@ozyx ozyx added this to the Target:3.1.0 milestone Sep 22, 2023
@shefalijoshi
Copy link
Contributor

Verified fixed.

@ozyx
Copy link
Member

ozyx commented Oct 3, 2023

verified that the compass HUD no longer shows in our testing environment, but I cannot get the HUD to come back when passing showCompassHUD: true in the ExampleImagery options:

    openmct.install(
      openmct.plugins.example.ExampleImagery({
        showCompassHUD: true
      })
    );

Edit:

Verified fixed if I alter the ImageryPlugin install step:

    this.install(
      ImageryPlugin.default({
        showCompassHUD: true
      })
    );

Closing this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants