Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eslint rule to catch bad use of innerHTML #7143

Closed
ozyx opened this issue Oct 12, 2023 · 2 comments · Fixed by #7144
Closed

Implement eslint rule to catch bad use of innerHTML #7143

ozyx opened this issue Oct 12, 2023 · 2 comments · Fixed by #7144
Labels
type:maintenance tests, chores, or project maintenance
Milestone
Target:3.1.1

Comments

@ozyx
Copy link
Member

ozyx commented Oct 12, 2023

Summary

Misuse of .innerHTML has bad implications for both security and performance. We should incorporate an eslint rule to check for bad usage of innerHTML and refactor it all out of our codebase.
@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Oct 12, 2023
@ozyx ozyx self-assigned this Oct 12, 2023
@ozyx ozyx mentioned this issue Oct 12, 2023
Merged
15 tasks
ozyx added a commit that referenced this issue Oct 16, 2023
@ozyx
fix(#7143): add eslint-plugin-no-sanitize and fix errors (#7144)
9849e03
ozyx added a commit that referenced this issue Oct 18, 2023
@ozyx
cherry-pick(#7144): fix(#7143): add eslint-plugin-no-unsanitized an…
4e95e12 
…d fix errors
@ozyx ozyx mentioned this issue Oct 18, 2023
Merged
ozyx added a commit that referenced this issue Oct 23, 2023
@ozyx
cherry-pick(#7144): fix(#7143): add eslint-plugin-no-unsanitized an…
ff8288d 
…d fix errors (#7148)
@ozyx ozyx added this to the Target:3.1.1 milestone Oct 23, 2023
@unlikelyzero
Copy link
Collaborator

Testing Notes

Plots and Flex layout regression testing

@unlikelyzero unlikelyzero assigned rukmini-bose and unassigned ozyx Oct 26, 2023
@rukmini-bose
Copy link
Contributor

Testathon 10/26/23, no major issues found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Milestone
Target:3.1.1
Development

Successfully merging a pull request may close this issue.

fix(#7143): add eslint-plugin-no-sanitize and fix errors nasa/openmct
3 participants
@ozyx @unlikelyzero @rukmini-bose