Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Imagery Snapshotting #3963 #4001

Merged
merged 16 commits into from Jul 10, 2021
Merged

Fixes for Imagery Snapshotting #3963 #4001

merged 16 commits into from Jul 10, 2021

Conversation

charlesh88
Copy link
Contributor

@charlesh88 charlesh88 commented Jul 9, 2021

Fixes #3963. Changes and refactoring for imagery Snapshotting to cope with html2canvas shortcomings.

Todos

  • Fix linting.
  • Make sure test code in Compass.vue is acceptable; change or remove if not.
  • Make sure tests aren't broken.
  • Add testing notes to original issue.
  • Add changes overview to this PR.

Changes

  • Update to latest version of html2canvas 1.0.0-rc7;
  • Better sizing and positioning for compass rose element;
  • Compass rose rewritten as SVG for compatibility with html2canvas;
  • Imagery view now hides local controls, pause button and prev/next arrows when taking a Snapshot;

All Submissions:

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

nikhilmandlik and others added 11 commits July 1, 2021 15:57
- Completely new SVG-based markup for compass rose;
- Associated CSS classes;
- VERY WIP!
- Significant progress on SVG markup;
- Wired up elements for data-driven transforms;
- New approach to NSEW text for html2canvas compatibility;
- WIP!
- Wired up responsive sizing to new markup;
- Refined opacity of compass black bg;
- Suppress Imagery view's local controls and Pause button when taking a
Snapshot;
- Added test mode code to Compass.vue;
- Refined test mode code in Compass.vue;
@charlesh88 charlesh88 changed the title Html2canvas 3963 Refactoring for html2canvas #3963 Jul 9, 2021
@charlesh88 charlesh88 changed the title Refactoring for html2canvas #3963 Fixes for Imagery Snapshotting #3963 Jul 9, 2021
@charlesh88 charlesh88 requested a review from akhenry July 9, 2021 01:46
@nikhilmandlik nikhilmandlik marked this pull request as ready for review July 9, 2021 23:21
@akhenry
Copy link
Contributor

akhenry commented Jul 10, 2021

Reviewer Checklist

  1. Changes appear to address issue? Y
  2. Appropriate unit tests included? N/A - Visual fixes
  3. Code style and in-line documentation are appropriate? Y
  4. Commit messages meet standards? Y
  5. Has associated issue been labelled unverified? (only applicable if this PR closes the issue) Y

@akhenry akhenry merged commit 41b860a into master Jul 10, 2021
@akhenry akhenry deleted the html2canvas-3963 branch July 10, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notebook Snapshots] Snapshots of Imagery views have a number of issues
3 participants