New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Imagery Snapshotting #3963 #4001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Completely new SVG-based markup for compass rose; - Associated CSS classes; - VERY WIP!
- Significant progress on SVG markup; - Wired up elements for data-driven transforms; - New approach to NSEW text for html2canvas compatibility; - WIP!
- Wired up responsive sizing to new markup;
- Refined opacity of compass black bg;
- Suppress Imagery view's local controls and Pause button when taking a Snapshot;
- Added test mode code to Compass.vue;
- Refined test mode code in Compass.vue;
charlesh88
changed the title
Refactoring for html2canvas #3963
Fixes for Imagery Snapshotting #3963
Jul 9, 2021
akhenry
requested changes
Jul 9, 2021
- Remove janky testing code in advance of better approach from Nikhil; - Code cleanups;
akhenry
approved these changes
Jul 10, 2021
Reviewer Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3963. Changes and refactoring for imagery Snapshotting to cope with html2canvas shortcomings.
Todos
Changes
All Submissions:
Author Checklist