Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent default on click events for conductor delta buttons #4033

Merged
merged 1 commit into from Jul 16, 2021
Merged

Prevent default on click events for conductor delta buttons #4033

merged 1 commit into from Jul 16, 2021

Conversation

khalidadil
Copy link
Contributor

Fixes #4017

Author Checklist

Check Passed
Changes address original issue? Y
Unit tests included and/or updated with changes? N/A
Command line build passes? Y
Changes have been smoke-tested? Y
Testing instructions included? N/A

Testing instructions are included in #4017

@shefalijoshi shefalijoshi mentioned this pull request Jul 16, 2021
Closed
7 tasks
@shefalijoshi shefalijoshi self-requested a review July 16, 2021 17:56
shefalijoshi
shefalijoshi approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@shefalijoshi shefalijoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for creating a new PR.

@shefalijoshi
Copy link
Contributor

shefalijoshi commented Jul 16, 2021 •
edited

Reviewer Checklist

  • Changes appear to address issue?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)
  • List of Acceptance Tests Performed.

@shefalijoshi shefalijoshi merged commit e3999fd into nasa:1.7.5 Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefalijoshi shefalijoshi shefalijoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khalidadil @shefalijoshi