New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4483] Safely lowercase strings for case insensitive comparison #4499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
==========================================
+ Coverage 69.36% 69.83% +0.47%
==========================================
Files 994 1019 +25
Lines 35806 36813 +1007
Branches 1629 1589 -40
==========================================
+ Hits 24838 25710 +872
- Misses 10564 10697 +133
- Partials 404 406 +2
Continue to review full report at Codecov.
|
@davetsay - The external lowercasing function + string casting was removed in favor of lowercasing inline. Let me know if any further changes are needed before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewer Checklist
Changes appear to address issue? | Y |
Appropriate unit tests included? | N/A |
Code style and in-line documentation are appropriate? | Y |
Commit messages meet standards? | Y |
Has associated issue been labelled unverified ? |
Y |
Closes #4483
All Submissions:
Author Checklist