Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add browserlist and linting capability #4811

Merged
merged 12 commits into from
Mar 21, 2022
Merged

[Docs] add browserlist and linting capability #4811

merged 12 commits into from
Mar 21, 2022

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Jan 28, 2022

Note:
Currently failing due to a webpack bug webpack/webpack#2933 (comment)

Closes #4802

Describe your changes:

This adds the bare minimum support for the browserlist ecosystem. With additional time and tooling, we should be able to run our linter based on our published browser support instead of running a large matrix of e2e tests.

https://github.com/browserslist/browserslist

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero changed the title add browserlist to package.json [Docs] add browserlist to package.json Jan 28, 2022
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #4811 (1e3f9d9) into master (d80b692) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4811      +/-   ##
==========================================
+ Coverage   50.46%   50.49%   +0.02%     
==========================================
  Files         497      497              
  Lines       18401    18401              
  Branches     1657     1657              
==========================================
+ Hits         9286     9291       +5     
+ Misses       8701     8696       -5     
  Partials      414      414              
Impacted Files Coverage Δ
src/plugins/notebook/components/Notebook.vue 23.57% <ø> (ø)
...c/plugins/persistence/couch/CouchObjectProvider.js 82.22% <0.00%> (+0.44%) ⬆️
src/api/objects/ObjectAPI.js 93.37% <0.00%> (+2.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80b692...1e3f9d9. Read the comment docs.

@unlikelyzero
Copy link
Collaborator Author

Waiting on feedback from Vickie and Andrew

@unlikelyzero
Copy link
Collaborator Author

Note: I attempted to use defaults and found the following:

npm run lint
...
✖ 200 problems (195 errors, 5 warnings)
...
/openmct/src/utils/clipboard.js
  4:16  error  navigator.clipboard() is not supported in iOS Safari 12.2-12.5  compat/compat
  9:16  error  navigator.clipboard() is not supported in iOS Safari 12.2-12.5  compat/compat
/openmct/src/plugins/notebook/components/Notebook.vue
  441:32  error  screen.orientation() is not supported in Safari 14.1, iOS Safari 12.2-12.5  compat/compat

@unlikelyzero unlikelyzero changed the title [Docs] add browserlist to package.json [Docs] add browserlist and linting capability Feb 17, 2022
@jvigliotta
Copy link
Contributor

@scottbell to take a look.

@jvigliotta jvigliotta requested review from scottbell and removed request for shefalijoshi March 7, 2022 22:14
.eslintrc.js Show resolved Hide resolved
Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing due to linting error

@@ -454,6 +454,8 @@ export default {
const classList = document.querySelector('body').classList;
const isPhone = Array.from(classList).includes('phone');
const isTablet = Array.from(classList).includes('tablet');
// address in https://github.com/nasa/openmct/issues/4875
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@scottbell scottbell merged commit 7b2ff8f into master Mar 21, 2022
@unlikelyzero unlikelyzero deleted the browserlist branch March 21, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Make browser support explicit
4 participants