-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] add browserlist and linting capability #4811
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4811 +/- ##
==========================================
+ Coverage 50.46% 50.49% +0.02%
==========================================
Files 497 497
Lines 18401 18401
Branches 1657 1657
==========================================
+ Hits 9286 9291 +5
+ Misses 8701 8696 -5
Partials 414 414
Continue to review full report at Codecov.
|
Waiting on feedback from Vickie and Andrew |
Note: I attempted to use defaults and found the following:
|
@scottbell to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing due to linting error
@@ -454,6 +454,8 @@ export default { | |||
const classList = document.querySelector('body').classList; | |||
const isPhone = Array.from(classList).includes('phone'); | |||
const isTablet = Array.from(classList).includes('tablet'); | |||
// address in https://github.com/nasa/openmct/issues/4875 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Note:
Currently failing due to a webpack bug webpack/webpack#2933 (comment)
Closes #4802
Describe your changes:
This adds the bare minimum support for the browserlist ecosystem. With additional time and tooling, we should be able to run our linter based on our published browser support instead of running a large matrix of e2e tests.
https://github.com/browserslist/browserslist
All Submissions:
Author Checklist
Reviewer Checklist