Fix stackplots static style #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added the ability to pass the element you would like to enlarge to the view large action * Example of performance marks (#5027) Co-authored-by: John Hill <john.c.hill@nasa.gov> Co-authored-by: unlikelyzero <jchill2@gmail.com> Co-authored-by: Andrew Henry <andrew.k.henry@nasa.gov>
* adding transactions to notebook entry editing Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov> Co-authored-by: Andrew Henry <andrew.k.henry@nasa.gov>
… prevents any ambiguity about which element should receive the style
Codecov Report
@@ Coverage Diff @@
## master #5045 +/- ##
==========================================
+ Coverage 49.84% 49.90% +0.05%
==========================================
Files 556 534 -22
Lines 20393 19549 -844
Branches 1876 1767 -109
==========================================
- Hits 10164 9755 -409
+ Misses 9736 9348 -388
+ Partials 493 446 -47
Continue to review full report at Codecov.
|
|
sorry @shefalijoshi , i think i let this get stale and now its out of sync with master |
…ckplots-static-style
|
@nikhilmandlik , can you take a look at this one? |
| * @private | ||
| */ | ||
| _onCancel() { | ||
| //noop |
There was a problem hiding this comment.
ahh thanks,
there are more like this tracked here, #4864
nikhilmandlik
suggested changes
May 10, 2022
|
Needs testing fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4912 #4864
Describe your changes:
The StyleRuleManager was subscribing to condition set updates even when it was destroyed (via a promise). Now we check to make sure that the StyleRuleManager is not destroyed when we handle the promise.
Cancelling the properties dialog was not handled. Added a handler for this.
All Submissions:
Author Checklist
Reviewer Checklist