Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add console error checking to our e2e suite #5177

Merged
merged 13 commits into from
May 13, 2022
Merged

Add console error checking to our e2e suite #5177

merged 13 commits into from
May 13, 2022

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented May 9, 2022 •
edited by davetsay

Closes #5000

Describe your changes:

  • This allows us to run our tests and detect errors during runtime.
  • Before merge it needs to be made available to all test suites
  • Baked into our e2e test template
  • We also need to audit all test suites which are already doing error detecting

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented May 9, 2022 •
edited

Codecov Report

Merging #5177 (ea38217) into master (b8d9e41) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5177      +/-   ##
==========================================
+ Coverage   49.88%   49.89%   +0.01%     
==========================================
  Files         534      534              
  Lines       19548    19548              
  Branches     1767     1767              
==========================================
+ Hits         9752     9754       +2     
+ Misses       9348     9346       -2     
  Partials      448      448
Impacted Files Coverage Δ
src/ui/router/Browse.js 86.48% <0.00%> (-1.36%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 83.55% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d9e41...ea38217. Read the comment docs.

@unlikelyzero unlikelyzero changed the title Example of e2e console error checking Add console error checking to our e2e suite May 10, 2022
@unlikelyzero unlikelyzero added the pr:e2e Automatically triggers e2e tests to run label May 10, 2022
@github-actions
Copy link

Failure ❌ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2301485801

@unlikelyzero unlikelyzero marked this pull request as ready for review May 10, 2022 19:37
@unlikelyzero unlikelyzero added pr:e2e Automatically triggers e2e tests to run and removed pr:e2e Automatically triggers e2e tests to run labels May 11, 2022
@nasa nasa deleted a comment from github-actions bot May 11, 2022
@nasa nasa deleted a comment from github-actions bot May 11, 2022
@github-actions
Copy link

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2308737837

@nasa nasa deleted a comment from github-actions bot May 11, 2022
@github-actions
Copy link

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2308737837

@github-actions
Copy link

Failure ❌ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2308737837

davetsay
davetsay approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/ISSUE_TEMPLATE/bug_report.md
@@ -40,6 +40,7 @@ assignees: ''
- [ ] Is there a workaround available?
- [ ] Does this impact a critical component?
- [ ] Is this just a visual bug with no functional impact?
- [ ] Does this block the execution of e2e tests?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

package.json
@@ -92,7 +92,7 @@
"test": "cross-env NODE_OPTIONS=\"--max_old_space_size=4096\" karma start --single-run",
"test:firefox": "cross-env NODE_OPTIONS=\"--max_old_space_size=4096\" karma start --single-run --browsers=FirefoxHeadless",
"test:debug": "cross-env NODE_ENV=debug karma start --no-single-run",
"test:e2e:ci": "npx playwright test --config=e2e/playwright-ci.config.js --project=chrome smoke default condition timeConductor branding clock",
"test:e2e:ci": "npx playwright test --config=e2e/playwright-ci.config.js --project=chrome smoke default condition timeConductor branding clock exampleImagery",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is clock case-sensitive? The e2e test is Clock.e2e.spec.js

@davetsay davetsay merged commit 09da373 into master May 13, 2022
@davetsay davetsay deleted the console-error-checking branch May 13, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetsay davetsay davetsay approved these changes

Assignees
No one assigned
Labels
pr:e2e Automatically triggers e2e tests to run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[e2e] Add console error detection to all of our e2e tests
3 participants
@unlikelyzero @davetsay @johnhill2