Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vista tc latest #5454

Closed
wants to merge 3 commits into from
Closed

Vista tc latest #5454

wants to merge 3 commits into from

Conversation

jvigliotta
Copy link
Contributor

@jvigliotta jvigliotta commented Jul 7, 2022

IN DRAFT PENDING NEEDING TO PATCH R4.9 OR NOT. CODE ALREADY MERGED INTO R4.10

Directly related to #5419

Describe your changes:

When options.strategy = 'latest' for a request, we should only hold onto one value... the latest one within the current time bounds. This fix adds logic for processing new telemetry to only take the latest one within the new telemetry and bounds. Also, on ticks, old telemetry is discarded and any future bound telemetry is then checked for latest values.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@jvigliotta jvigliotta requested a review from davetsay July 7, 2022 21:02
@davetsay davetsay marked this pull request as draft July 15, 2022 17:48
@jvigliotta
Copy link
Contributor Author

This was implemented separately.

@jvigliotta jvigliotta closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant