Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5211 tests arent using source maps master #5566

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Jul 27, 2022

Closes #5211

Describe your changes:

This gets us closer to what we want with retaining line numbers:

1) uses source maps properly
     The Annotation API
     Error: Do source maps works
    at AnnotationAPI.fail (webpack-internal:///./src/api/annotation/AnnotationAPI.js:214:11)
    at UserContext.eval (webpack-internal:///./src/api/annotation/AnnotationAPISpec.js:95:35)
    at <Jasmine>

though per the docs, it can be a bit flaky still.

I also simplified the config a bit. We had an extra babel config file that didn't seem to need to exist outside the webpack coverage config.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Unit tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Changes appear not to be breaking changes?
  • Appropriate unit tests included?
  • Code style and in-line documentation are appropriate?
  • Commit messages meet standards?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell scottbell linked an issue Jul 27, 2022 that may be closed by this pull request
@scottbell scottbell requested review from akhenry and ozyx July 27, 2022 05:12
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #5566 (9c54a9f) into master (c83ee95) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 9c54a9f differs from pull request most recent head 7b88655. Consider uploading reports for the commit 7b88655 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5566   +/-   ##
=======================================
  Coverage   53.63%   53.64%           
=======================================
  Files         594      594           
  Lines       21762    21762           
  Branches     2047     2047           
=======================================
+ Hits        11673    11674    +1     
+ Misses       9516     9514    -2     
- Partials      573      574    +1     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.50% <ø> (+0.01%) ⬆️ Carriedforward from 029605e
e2e-full 48.81% <ø> (ø) Carriedforward from 029605e
e2e-stable 47.48% <ø> (ø)
unit 50.11% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ettingsSynchronizer/URLTimeSettingsSynchronizer.js 96.96% <0.00%> (-1.02%) ⬇️
src/plugins/gauge/components/Gauge.vue 61.72% <0.00%> (-0.62%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 80.00% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83ee95...7b88655. Read the comment docs.

@akhenry akhenry enabled auto-merge (squash) July 28, 2022 18:22
@akhenry akhenry merged commit e774eb0 into master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests aren't using source maps
2 participants