New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4417 fix codeql issues #5793
4417 fix codeql issues #5793
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5793 +/- ##
==========================================
- Coverage 54.12% 54.09% -0.03%
==========================================
Files 598 598
Lines 22945 22945
Branches 2076 2076
==========================================
- Hits 12418 12413 -5
- Misses 9945 9950 +5
Partials 582 582
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great!
Can you update our relevant documentation with why these matter?
Also, can you create a calendar event/ticket to remove LGTM in december 2022? It looks like it's shutting down
@michaelrogers it looks like app.js will be removed sooner than I thought. We should wait until #5797 is merged and then updated accordingly |
app.js has been removed. Can we move ahead with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. We just need to ignore **/*.spec.js
changes, and this is gtg
Closes #4417
Describe your changes:
All Submissions:
Author Checklist
Reviewer Checklist