-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#5975): Transaction-ify the CreateAction #6306
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6306 +/- ##
==========================================
- Coverage 55.03% 55.00% -0.03%
==========================================
Files 607 607
Lines 26245 26254 +9
Branches 2395 2395
==========================================
- Hits 14444 14442 -2
- Misses 11137 11147 +10
- Partials 664 665 +1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e changes look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Closes #5975
Describe your changes:
Transaction-ifies the CreateAction as composable MutableDomainObjects in the tree were not having their compositions updated properly after creating a new child object.
All Submissions:
Author Checklist
Reviewer Checklist