Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#5975): Transaction-ify the CreateAction #6306

Merged
merged 6 commits into from
Mar 6, 2023
Merged

fix(#5975): Transaction-ify the CreateAction #6306

merged 6 commits into from
Mar 6, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Feb 8, 2023

Closes #5975

Describe your changes:

Transaction-ifies the CreateAction as composable MutableDomainObjects in the tree were not having their compositions updated properly after creating a new child object.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:2.1.6 milestone Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #6306 (b569be7) into master (8040b27) will decrease coverage by 0.03%.
The diff coverage is 92.85%.

❗ Current head b569be7 differs from pull request most recent head d205095. Consider uploading reports for the commit d205095 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6306      +/-   ##
==========================================
- Coverage   55.03%   55.00%   -0.03%     
==========================================
  Files         607      607              
  Lines       26245    26254       +9     
  Branches     2395     2395              
==========================================
- Hits        14444    14442       -2     
- Misses      11137    11147      +10     
- Partials      664      665       +1     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.46% <100.00%> (+0.01%) ⬆️ Carriedforward from 838f8e0
e2e-full 51.19% <100.00%> (+<0.01%) ⬆️ Carriedforward from 838f8e0
e2e-stable 54.31% <69.23%> (-0.04%) ⬇️
unit 49.62% <69.23%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/formActions/CreateAction.js 94.62% <92.85%> (-3.00%) ⬇️
src/utils/staleness.js 66.66% <0.00%> (-28.58%) ⬇️
src/ui/mixins/staleness-mixin.js 66.66% <0.00%> (-22.23%) ⬇️
src/plugins/plot/draw/DrawWebGL.js 90.09% <0.00%> (-1.99%) ⬇️
example/generator/SinewaveStalenessProvider.js 86.27% <0.00%> (-1.97%) ⬇️
src/api/time/IndependentTimeContext.js 85.56% <0.00%> (-0.90%) ⬇️
src/plugins/gauge/components/Gauge.vue 62.04% <0.00%> (-0.61%) ⬇️
src/api/telemetry/TelemetryAPI.js 86.15% <0.00%> (-0.39%) ⬇️
src/ui/components/tags/TagSelection.vue 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8040b27...d205095. Read the comment docs.

@ozyx ozyx marked this pull request as ready for review February 8, 2023 20:01
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Feb 8, 2023
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels Feb 8, 2023
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e changes look good to me!

@akhenry akhenry modified the milestones: Target:2.1.6, Target:2.2.0 Feb 9, 2023
@shefalijoshi shefalijoshi requested review from jvigliotta and removed request for davetsay and akhenry February 27, 2023 21:40
Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work!

@jvigliotta jvigliotta enabled auto-merge (squash) March 6, 2023 21:53
@jvigliotta jvigliotta merged commit f388d9a into master Mar 6, 2023
@jvigliotta jvigliotta deleted the mct5975 branch March 6, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree sporadically doesn't update from composition changes
4 participants