Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have clicking on annotation search result use the preview action if in edit mode #6331

Conversation

scottbell
Copy link
Contributor

@scottbell scottbell commented Feb 13, 2023

Closes #6280

Describe your changes:

Handle edit mode in annotation results.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@scottbell
Copy link
Contributor Author

Note, I ran the unit tests 30 times in parallel with the search suite enabled and didn't get any test failures. Hopefully that persists!

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #6331 (de59372) into master (6d62e0e) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6331      +/-   ##
==========================================
- Coverage   55.02%   54.97%   -0.06%     
==========================================
  Files         607      607              
  Lines       26235    26242       +7     
  Branches     2395     2397       +2     
==========================================
- Hits        14437    14427      -10     
- Misses      11133    11148      +15     
- Partials      665      667       +2     
Flag Coverage Δ *Carryforward flag
e2e-ci 39.44% <ø> (ø) Carriedforward from 1fde129
e2e-full 51.19% <ø> (ø) Carriedforward from 1fde129
e2e-stable 54.05% <ø> (-0.01%) ⬇️
unit 49.62% <0.00%> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/ui/layout/search/AnnotationSearchResult.vue 0.00% <0.00%> (ø)
src/ui/layout/search/ObjectSearchResult.vue 0.00% <0.00%> (ø)
example/generator/SinewaveStalenessProvider.js 84.31% <0.00%> (-1.97%) ⬇️
...c/plugins/persistence/couch/CouchObjectProvider.js 45.23% <0.00%> (-0.75%) ⬇️
src/plugins/gauge/components/Gauge.vue 62.04% <0.00%> (-0.61%) ⬇️
src/plugins/plot/chart/MctChart.vue 46.81% <0.00%> (-0.50%) ⬇️
src/plugins/imagery/components/ImageryView.vue 44.21% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d62e0e...de59372. Read the comment docs.

@scottbell scottbell changed the title 6280 click on search result annotation in this case switches view while in edit mode Have clicking on annotation search result use the preview action if in edit mode Feb 13, 2023
@ozyx ozyx added this to the Target:2.2.0 milestone Feb 13, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Tested with both object and annotation search results and it worked well. I've left just a couple comments. We might be able to add e2e test coverage for this fairly easily so as not to be blocked by the ongoing unit test router flake issue (😔)

src/ui/layout/search/AnnotationSearchResult.vue Outdated Show resolved Hide resolved
src/ui/layout/search/GrandSearchSpec.js Outdated Show resolved Hide resolved
@scottbell scottbell requested a review from ozyx February 14, 2023 11:17
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozyx ozyx merged commit 8de24a1 into master Feb 14, 2023
@ozyx ozyx deleted the 6280-click-on-search-result-annotation-in-this-case-switches-view-while-in-edit-mode branch February 14, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on Search Result (Annotation in this case) switches view while in Edit mode
2 participants