-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have clicking on annotation search result use the preview action if in edit mode #6331
Have clicking on annotation search result use the preview action if in edit mode #6331
Conversation
Note, I ran the unit tests 30 times in parallel with the search suite enabled and didn't get any test failures. Hopefully that persists! |
Codecov Report
@@ Coverage Diff @@
## master #6331 +/- ##
==========================================
- Coverage 55.02% 54.97% -0.06%
==========================================
Files 607 607
Lines 26235 26242 +7
Branches 2395 2397 +2
==========================================
- Hits 14437 14427 -10
- Misses 11133 11148 +15
- Partials 665 667 +2
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
…this-case-switches-view-while-in-edit-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Tested with both object and annotation search results and it worked well. I've left just a couple comments. We might be able to add e2e test coverage for this fairly easily so as not to be blocked by the ongoing unit test router flake issue (😔)
…this-case-switches-view-while-in-edit-mode
…this-case-switches-view-while-in-edit-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #6280
Describe your changes:
Handle edit mode in annotation results.
All Submissions:
Author Checklist
Reviewer Checklist