[Missing Object] Notifications are shown as minimized #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidadil
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6416 +/- ##
==========================================
- Coverage 54.98% 54.65% -0.33%
==========================================
Files 620 620
Lines 26490 26494 +4
Branches 2392 2392
==========================================
- Hits 14565 14480 -85
- Misses 11281 11367 +86
- Partials 644 647 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…nto bugfix/issue-6349
…ssing/type unknown
… using the telemetry API under the hood and add check for historical data
| @@ -108,6 +108,24 @@ describe('The Notifiation API', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('the error method notificiation', () => { | |||
There was a problem hiding this comment.
At some point we should add a test to see that if a new notification comes in while the notifications are being viewed, that they don't end up being minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6349
Describe your changes:
Adds the ability to pass
minimized: trueto error notifications show those notifications as minimized. Also shows missing object error notifications as minimized by default.All Submissions:
Author Checklist
Reviewer Checklist