Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to entries #6464

Merged
merged 6 commits into from
Mar 17, 2023
Merged

fixes to entries #6464

merged 6 commits into from
Mar 17, 2023

Conversation

davetsay
Copy link
Contributor

@davetsay davetsay commented Mar 17, 2023

Closes #6354

Describe your changes:

  • fix delete first notebook entry
  • fix select unfocused on create

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

fix delete first notebook entry

fix select unfocused on create
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@201c669). Click here to learn what that means.
The diff coverage is 0.00%.

❗ Current head ab0583c differs from pull request most recent head 3d82743. Consider uploading reports for the commit 3d82743 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6464   +/-   ##
=========================================
  Coverage          ?   54.86%           
=========================================
  Files             ?      626           
  Lines             ?    26638           
  Branches          ?     2407           
=========================================
  Hits              ?    14615           
  Misses            ?    11360           
  Partials          ?      663           
Flag Coverage Δ *Carryforward flag
e2e-ci 39.35% <ø> (?) Carriedforward from 1b7fb9b
e2e-full 51.07% <ø> (?) Carriedforward from 1b7fb9b
e2e-stable 55.53% <ø> (?)
unit 49.18% <0.00%> (?)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/notebook/components/Notebook.vue 20.63% <0.00%> (ø)
src/plugins/notebook/components/NotebookEntry.vue 16.79% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201c669...3d82743. Read the comment docs.

Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAM! Nicely done!

@jvigliotta jvigliotta enabled auto-merge (squash) March 17, 2023 20:16
@akhenry akhenry added the sim-3 label Mar 17, 2023
@jvigliotta jvigliotta merged commit 453b1f3 into master Mar 17, 2023
@jvigliotta jvigliotta deleted the fix/6354 branch March 17, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Enter key in Notebook entry to add new lines by default
3 participants