fix(#6549): [StaticRootPlugin] Remap non-empty root namespaces and non-root namespaces correctly #6583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the issue of the Static Root provider overriding existing namespaces, such as those from a telemetry dictionary - Fixes the issue of keys of child objects NOT present in the idMapping (such as those from a telemetry dictionary) being overwritten as undefined - TODO: This will not work for objects exported from an environment that has the "MyItems" namespace defined to anything other than an empty string. Need to figure out how to handle this.
Current Playwright Test Results Summary✅ 12 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/14/2023 11:09:49pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 6ba8aa0 Started: 04/14/2023 11:08:17pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1 • Initial Attempt |
0% (0)0 / 16 runsfailed over last 7 days |
56.25% (9)9 / 16 runsflaked over last 7 days |
|
CouchDB Status Indicator with mocked responses @couchdb Shows unknown if it receives an unexpected response code
Retry 1 • Initial Attempt |
0% (0)0 / 16 runsfailed over last 7 days |
37.50% (6)6 / 16 runsflaked over last 7 days |
📄 functional/forms.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Persistence operations @couchdb Can create an object after a conflict error @couchdb @2p
Retry 1 • Initial Attempt |
0% (0)0 / 13 runsfailed over last 7 days |
76.92% (10)10 / 13 runsflaked over last 7 days |
ozyx
changed the title
ozyx
added
pr:e2e:couchdb
Codecov Report
@@ Coverage Diff @@
## master #6583 +/- ##
==========================================
+ Coverage 52.38% 54.99% +2.61%
==========================================
Files 626 626
Lines 26460 26469 +9
Branches 2422 2422
==========================================
+ Hits 13861 14557 +696
+ Misses 11932 11245 -687
Partials 667 667
*This pull request uses carry forward flags. Click here to find out more.
... and 92 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6549 #6584
Describe your changes:
"").All Submissions:
Author Checklist
Reviewer Checklist