Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Gantt Chart displays draft status of Plan in composition #6642

Merged
merged 5 commits into from
May 5, 2023
Merged

fix: Gantt Chart displays draft status of Plan in composition #6642

merged 5 commits into from
May 5, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented May 4, 2023

Closes #6641 VIPEROMCT-303

Describe your changes:

The Gantt Chart view was not respecting / displaying the draft status of a Plan if it was in its composition. This updates the logic to set the status when a domainObject is added in composition.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx added this to the Target:2.2.3 milestone May 4, 2023
@deploysentinel
Copy link

deploysentinel bot commented May 4, 2023 •
edited

Current Playwright Test Results Summary

✅ 12 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/05/2023 11:48:21pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 8392d3a

Started: 05/05/2023 11:45:20pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt
0% (0) 0 / 27 runs
failed over last 7 days
44.44% (12) 12 / 27 runs
flaked over last 7 days

View Detailed Build Results

unlikelyzero
unlikelyzero reviewed May 4, 2023
View reviewed changes
src/plugins/plan/components/Plan.vue
@@ -232,6 +233,7 @@ export default {
this.planObject = domainObject;
this.swimlaneVisibility = this.configuration.swimlaneVisibility;
this.planData = getValidatedData(domainObject);
this.setStatus(this.openmct.status.get(domainObject.identifier));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a simple way to add coverage for this line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be covered by the e2e test I added? Wonder why that's not being picked up... 🤔

unlikelyzero
unlikelyzero approved these changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had a simple question on how to add coverage to the new line.

Also, if you have some cycles, it might be worth making a visual test for draft

@ozyx
Copy link
Member Author

ozyx commented May 4, 2023

LGTM. I had a simple question on how to add coverage to the new line.

Also, if you have some cycles, it might be worth making a visual test for draft

Good call. This really is more of a visual test anyway.

@ozyx ozyx force-pushed the gantt-chart-must-respect-draft-status-of-plan branch from 37b8342 to 1aacccf Compare May 5, 2023 21:07
@codecov
Copy link

codecov bot commented May 5, 2023 •
edited

Codecov Report

Merging #6642 (1aacccf) into master (f5eacc5) will decrease coverage by 0.43%.
The diff coverage is 0.00%.

❗ Current head 1aacccf differs from pull request most recent head 68afdcd. Consider uploading reports for the commit 68afdcd to get more accurate results

@@            Coverage Diff             @@
##           master    #6642      +/-   ##
==========================================
- Coverage   54.16%   53.73%   -0.43%     
==========================================
  Files         623      623              
  Lines       24374    24376       +2     
  Branches     2412     2412              
==========================================
- Hits        13202    13099     -103     
- Misses      10512    10618     +106     
+ Partials      660      659       -1
Flag Coverage Δ *Carryforward flag
e2e-full 31.35% <ø> (ø) Carriedforward from f5eacc5
e2e-stable 51.74% <ø> (-3.73%) ⬇️
unit 48.97% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/plan/components/Plan.vue 56.00% <0.00%> (-0.51%) ⬇️

... and 22 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f07925...68afdcd. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label May 5, 2023
@ozyx ozyx enabled auto-merge (squash) May 5, 2023 23:40
@ozyx ozyx added pr:e2e:couchdb npm run test:e2e:couchdb and removed pr:e2e:couchdb npm run test:e2e:couchdb labels May 5, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label May 5, 2023
@ozyx ozyx merged commit ba4353a into master May 5, 2023
11 of 13 checks passed
@ozyx ozyx deleted the gantt-chart-must-respect-draft-status-of-plan branch May 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unlikelyzero unlikelyzero unlikelyzero approved these changes

@shefalijoshi shefalijoshi Awaiting requested review from shefalijoshi

@michaelrogers michaelrogers Awaiting requested review from michaelrogers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Target:2.2.3
Development

Successfully merging this pull request may close these issues.

Gantt Chart view of plans does not observe draft status of plans
2 participants
@ozyx @unlikelyzero