Fix release 2.2.3 version #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozyx
approved these changes
May 22, 2023
Current Playwright Test Results Summary✅ 119 Passing - ❌ 1 Failing Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/22/2023 06:30:13pm UTC) ❌ Failures📄 framework/baseFixtures.e2e.spec.js • 1 FailureTest Case Results
|
unlikelyzero
added a commit
that referenced
this pull request
Jul 14, 2023
* cherry-pick(#6602) : [ExportAsJson] Multiple Aliases in Export and Co… (#6658) cherry-pick(#6602) : [ExportAsJson] Multiple Aliases in Export and Conditional Styles Fixes (#6602) Fixes issues that prevent import and export from being completed successfully. Specifically: * if multiple aliases are detected, the first is created as a new object and and added to it's parent's composition, any subsequent aliases of the same object will not be recreated, but the originally created one will be added to the current parent's composition, creating an alias. * Also, there are cases were conditionSetIdentifiers are stored in an object keyed by an item id in the configuration.objectstyles object, this fix will handle these as well. * Replaces an errant `return` statement with a `continue` statement to prevent early exit from a recursive function. --------- Co-authored-by: Andrew Henry <akhenry@gmail.com> * chore: bump version to `2.2.3` (#6685) * Add configuration detection to update table rows in place * Fix typo for datum access * First add new rows to the table and then update rows in place * Each row much be checked for in place updates and inserted as needed * Fix typo. Remove unused code. * Update datum only. And don't allow undefined values for columns * Fix typo * Rename function for clarity * Use telemetry metadata to indicate datum property to use for in place updates * Fix typo for method call * Fix typo for return value * fullDatum is the datum BEFORE normalizing. --------- Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov> Co-authored-by: Andrew Henry <akhenry@gmail.com> Co-authored-by: John Hill <john.c.hill@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Remove snapshot from release version
All Submissions:
Author Checklist
Reviewer Checklist