Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time] Conductors and API Enhancements #6768

Merged
merged 117 commits into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from 112 commits
Commits
Show all changes
117 commits
Select commit Hold shift + click to select a range
e86c741
Fixed #4975 - Compact Time Conductor styling
charlesh88 May 13, 2022
c61fa04
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 14, 2022
3e7e9d5
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 14, 2022
bc20d89
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
26c592f
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
5fa4898
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
7247a42
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
7f97441
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
65801de
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 17, 2022
5db595d
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 18, 2022
e743e09
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 18, 2022
b744594
Fixes #4975 - Compact Time Conductor styling
charlesh88 May 18, 2022
485ff91
Closes #4975
charlesh88 Apr 6, 2023
170686a
Initial work on getting the conductor popup working
shefalijoshi Apr 17, 2023
baf41fb
Ensure toggling between fixed timespan and clock modes works. Save cl…
shefalijoshi Apr 19, 2023
995a10b
Save fixed time bounds
shefalijoshi Apr 19, 2023
9d256ac
Ensure conductor history works when mode is switched. Submit and canc…
shefalijoshi Apr 20, 2023
db04cf1
Add independent time conductor popup logic
shefalijoshi Apr 21, 2023
36a0fe9
Independent time conductor popup draft
shefalijoshi Apr 24, 2023
3c86c43
object path for independent time conductor
shefalijoshi Apr 25, 2023
f1398cf
Ensure independent time conductor mode works as expected
shefalijoshi Apr 25, 2023
84882be
Ensure that clock changes are reflected downstream
shefalijoshi Apr 25, 2023
2bbe713
manually cherry picking over my changes to this existing branch
jvigliotta Apr 26, 2023
6f5e3d2
WIP
jvigliotta Apr 28, 2023
2179bc4
Stubs for the new Time API methods
shefalijoshi Apr 26, 2023
d847b26
WIP
jvigliotta May 2, 2023
668e88a
WIP
jvigliotta May 10, 2023
7578d33
various changes for setting modes and clocks, also updates to conduct…
jvigliotta May 10, 2023
05c0042
moved conductor popup into conductor instead of creating the componen…
jvigliotta May 10, 2023
b4454ad
WIP: lots of updates to methods and moving component creation from pr…
jvigliotta May 19, 2023
e4497f5
working on independent time conductor part
jvigliotta May 22, 2023
dbeb7c4
WIP
jvigliotta May 22, 2023
f1a89e0
realtime working on load
jvigliotta May 23, 2023
727eaa8
updated xAxis to new api, it was thrwoing many warnings for calling .…
jvigliotta May 23, 2023
d464ded
cleaning up some items
jvigliotta May 24, 2023
a24df42
using constants for events in the conductor components
jvigliotta May 24, 2023
5aca274
forgot one
jvigliotta May 24, 2023
546662a
itc work, moving mutating the domain object into itc so its in one place
jvigliotta May 24, 2023
0e9542c
cleanup
jvigliotta May 24, 2023
55342a0
various changes, but mainly changes to independent time context
jvigliotta May 24, 2023
2585c80
WIP
jvigliotta Jun 1, 2023
4a37475
stil WIP, but progress made on independent and regular conductor popu…
jvigliotta Jun 15, 2023
3923d02
WIP
jvigliotta Jun 20, 2023
6a45e2e
Shefali fixes! thanks!
jvigliotta Jun 26, 2023
62d14ed
prevent flash after appending conductor popup to body element
jvigliotta Jun 27, 2023
fdf405c
fixing buttons and when they hide
jvigliotta Jun 27, 2023
fc453ee
cleaning up
jvigliotta Jun 27, 2023
94c1cc6
more cleaning up
jvigliotta Jun 27, 2023
7169ca9
updating styles for popups that pop out
jvigliotta Jun 27, 2023
956c9a5
weird dupe event, maybe from toggle?
jvigliotta Jun 27, 2023
1e97049
small change
jvigliotta Jun 27, 2023
e16f4fc
refactor: format with prettier
jvigliotta Jun 28, 2023
2403228
merging prettier, fixing conflicts
jvigliotta Jun 28, 2023
e9f4793
adding read only mode, clock and timesystem to conductor and some cle…
jvigliotta Jun 29, 2023
7ed5b42
adding back a newline at end of file
jvigliotta Jun 29, 2023
903540d
updates related to stopping clocks
jvigliotta Jun 29, 2023
02c30c5
remvoing commented code
jvigliotta Jun 29, 2023
e9f806e
some pre pr review review changes
jvigliotta Jun 29, 2023
959b4ee
lint fixes
jvigliotta Jun 29, 2023
2762f5d
fixed panning and zooming styles as well as the ability to pan and zo…
jvigliotta Jul 11, 2023
c55f27e
making sure mode is respected in conductor and emitting new bounds ev…
jvigliotta Jul 11, 2023
b909207
fix typo
jvigliotta Jul 11, 2023
6edbb67
Fixes instances of the old Time API being called
shefalijoshi Jul 11, 2023
c8595ee
Merge branch 'mode-dropdown' of https://github.com/nasa/openmct into …
jvigliotta Jul 11, 2023
80cae84
WIP
jvigliotta Jul 11, 2023
0947794
separate mode and clock mixin, constants in url time sync, reactive c…
jvigliotta Jul 11, 2023
fa5de7c
typo fix and removing unused vars
jvigliotta Jul 11, 2023
b8ab9a6
remove console log, revert incorrect logic in url time sync
jvigliotta Jul 11, 2023
1d72a15
removing older code, more descerning object frame in regard to itc
jvigliotta Jul 11, 2023
2c7b27d
Merge branch 'master' into mode-dropdown
jvigliotta Jul 12, 2023
22fb33b
Closes #4975
charlesh88 Jul 12, 2023
045b6fd
Merge branch 'mode-dropdown' of github.com:nasa/openmct into mode-dro…
charlesh88 Jul 12, 2023
ee8bc16
handling clock updates when in fixed mode
jvigliotta Jul 12, 2023
dac4c52
Merge branch 'mode-dropdown' of https://github.com/nasa/openmct into …
jvigliotta Jul 12, 2023
f90f6d6
Closes #4975
charlesh88 Jul 12, 2023
39a3b49
Merge branch 'mode-dropdown' of github.com:nasa/openmct into mode-dro…
charlesh88 Jul 12, 2023
bef67c8
Closes #4975
charlesh88 Jul 13, 2023
be793dc
Closes #4975
charlesh88 Jul 13, 2023
b5a8a2b
Closes #4975
charlesh88 Jul 13, 2023
e8926da
Closes #4975
charlesh88 Jul 13, 2023
43602d9
fixed positioning of popup if window is resized to prevent "jumping",…
jvigliotta Jul 13, 2023
40e53e0
Closes #4975
charlesh88 Jul 13, 2023
4e788f7
Merge branch 'mode-dropdown' of github.com:nasa/openmct into mode-dro…
charlesh88 Jul 13, 2023
4d28763
Closes #4975
charlesh88 Jul 13, 2023
3cb2fef
pretty substantial rewrite of conductor history
jvigliotta Jul 14, 2023
9404384
Closes #4975
charlesh88 Jul 14, 2023
ca0d411
Merge remote-tracking branch 'origin/mode-dropdown' into mode-dropdown
charlesh88 Jul 14, 2023
1de96e6
Merge branch 'master' into mode-dropdown
jvigliotta Jul 14, 2023
6d1b2ef
updating setters
jvigliotta Jul 14, 2023
a17566c
Merge branch 'master' into mode-dropdown
jvigliotta Jul 14, 2023
47dce7b
Merge branch 'master' into mode-dropdown
akhenry Jul 14, 2023
db33539
somehow forgot to be backwards compatible
jvigliotta Jul 14, 2023
0a2de2a
[Global Clock] Clock, Clock Indicator, Timer and Notebook entries (#6…
jvigliotta Jul 14, 2023
60c260d
Merge branch 'master' into mode-dropdown
jvigliotta Jul 14, 2023
0f2b73e
fixing tests for new clock functionality
jvigliotta Jul 15, 2023
ed8b75d
Merge branch 'master' of https://github.com/nasa/openmct into mode-dr…
shefalijoshi Jul 15, 2023
6adc14e
fixing time api spec tests
jvigliotta Jul 15, 2023
c1ee1e0
Merge branch 'mode-dropdown' of https://github.com/nasa/openmct into …
shefalijoshi Jul 15, 2023
19d5bb0
Merge branch 'master' into mode-dropdown
jvigliotta Jul 15, 2023
f898aa3
Uncomment test and add missing events
shefalijoshi Jul 15, 2023
1eb2810
Merge branch 'mode-dropdown' of https://github.com/nasa/openmct into …
shefalijoshi Jul 15, 2023
df6a3e4
imagery to use new time.now
jvigliotta Jul 15, 2023
d9c8a78
Merge branch 'master' into mode-dropdown
unlikelyzero Jul 17, 2023
7fa554b
Mode dropdown clock bounds fix (#6804)
shefalijoshi Jul 17, 2023
249f820
ImageryView 🖼️ + IndependentTimeConductor ⏰ (#6791)
scottbell Jul 17, 2023
da1ae38
Fix tests
shefalijoshi Jul 18, 2023
5de350e
Fix URLTimeSynchronizer takeovers
shefalijoshi Jul 18, 2023
5ce7754
Fix urlSpec test
shefalijoshi Jul 18, 2023
ae364e2
Disable a few unit tests. TODO fixes later.
shefalijoshi Jul 18, 2023
78c0f83
Fix timeConductor test
shefalijoshi Jul 18, 2023
7645dc9
Fix timelist tests
shefalijoshi Jul 18, 2023
46ac06f
Fix linting issues
shefalijoshi Jul 18, 2023
871b13f
comment out flaky tests
shefalijoshi Jul 18, 2023
b33a523
Fix some e2e tests
shefalijoshi Jul 18, 2023
043233f
Default local clock (#6807)
jvigliotta Jul 18, 2023
0a86d1d
Don't set bounds if not provided
shefalijoshi Jul 19, 2023
abda0b4
Add deprecation warning back
shefalijoshi Jul 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions API.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents**

- [Building Applications With Open MCT](#developing-applications-with-open-mct)
- [Developing Applications With Open MCT](#developing-applications-with-open-mct)
- [Scope and purpose of this document](#scope-and-purpose-of-this-document)
- [Building From Source](#building-from-source)
- [Starting an Open MCT application](#starting-an-open-mct-application)
Expand All @@ -26,7 +26,7 @@
- [Value Hints](#value-hints)
- [The Time Conductor and Telemetry](#the-time-conductor-and-telemetry)
- [Telemetry Providers](#telemetry-providers)
- [Telemetry Requests and Responses.](#telemetry-requests-and-responses)
- [Telemetry Requests and Responses](#telemetry-requests-and-responses)
- [Request Strategies **draft**](#request-strategies-draft)
- [`latest` request strategy](#latest-request-strategy)
- [`minmax` request strategy](#minmax-request-strategy)
Expand Down Expand Up @@ -873,6 +873,8 @@ function without any arguments.

#### Stopping an active clock

_As of July 2023, this method will be deprecated. Open MCT will always have a ticking clock._

The `stopClock` method can be used to stop an active clock, and to clear it. It
will stop the clock from ticking, and set the active clock to `undefined`.

Expand Down
12 changes: 6 additions & 6 deletions e2e/test-data/VisualTestData_storage.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,18 @@
"origin": "http://localhost:8080",
"localStorage": [
{
"name": "tcHistory",
"value": "{\"utc\":[{\"start\":1658617611983,\"end\":1658619411983}]}"
"name": "mct",
"value": "{\"mine\":{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"modified\":1689710399654,\"created\":1689710398656,\"persisted\":1689710399654},\"58f55f3a-46d9-4c37-a726-27b5d38b895a\":{\"identifier\":{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"},\"name\":\"Overlay Plot:b0ba67ab-e383-40c1-a181-82b174e8fdf0\",\"type\":\"telemetry.plot.overlay\",\"composition\":[{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"}],\"configuration\":{\"series\":[{\"identifier\":{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"}}]},\"notes\":\"framework/generateVisualTestData.e2e.spec.js\\nGenerate Visual Test Data @localStorage\\nchrome\",\"modified\":1689710400878,\"location\":\"mine\",\"created\":1689710399651,\"persisted\":1689710400878},\"19f2e461-190e-4662-8d62-251e90bb7aac\":{\"name\":\"Unnamed Sine Wave Generator\",\"type\":\"generator\",\"identifier\":{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"},\"telemetry\":{\"period\":10,\"amplitude\":1,\"offset\":0,\"dataRateInHz\":1,\"phase\":0,\"randomness\":0,\"loadDelay\":\"5000\",\"infinityValues\":false,\"staleness\":false},\"modified\":1689710400433,\"location\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"created\":1689710400433,\"persisted\":1689710400433}}"
},
{
"name": "mct",
"value": "{\"mine\":{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"7fa5749b-8969-494c-9d85-c272516d333c\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"persisted\":1658619412848,\"modified\":1658619412848},\"7fa5749b-8969-494c-9d85-c272516d333c\":{\"identifier\":{\"key\":\"7fa5749b-8969-494c-9d85-c272516d333c\",\"namespace\":\"\"},\"name\":\"Unnamed Overlay Plot\",\"type\":\"telemetry.plot.overlay\",\"composition\":[{\"key\":\"67cbb9fc-af46-4148-b9e5-aea11179ae4b\",\"namespace\":\"\"}],\"configuration\":{\"series\":[{\"identifier\":{\"key\":\"67cbb9fc-af46-4148-b9e5-aea11179ae4b\",\"namespace\":\"\"}}]},\"modified\":1658619413566,\"location\":\"mine\",\"persisted\":1658619413567},\"67cbb9fc-af46-4148-b9e5-aea11179ae4b\":{\"name\":\"Unnamed Sine Wave Generator\",\"type\":\"generator\",\"identifier\":{\"key\":\"67cbb9fc-af46-4148-b9e5-aea11179ae4b\",\"namespace\":\"\"},\"telemetry\":{\"period\":10,\"amplitude\":1,\"offset\":0,\"dataRateInHz\":1,\"phase\":0,\"randomness\":0,\"loadDelay\":\"5000\"},\"modified\":1658619413552,\"location\":\"7fa5749b-8969-494c-9d85-c272516d333c\",\"persisted\":1658619413552}}"
"name": "mct-recent-objects",
"value": "[{\"objectPath\":[{\"identifier\":{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"},\"name\":\"Overlay Plot:b0ba67ab-e383-40c1-a181-82b174e8fdf0\",\"type\":\"telemetry.plot.overlay\",\"composition\":[{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"}],\"configuration\":{\"series\":[]},\"notes\":\"framework/generateVisualTestData.e2e.spec.js\\nGenerate Visual Test Data @localStorage\\nchrome\",\"modified\":1689710400435,\"location\":\"mine\",\"created\":1689710399651,\"persisted\":1689710400436},{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"modified\":1689710399654,\"created\":1689710398656,\"persisted\":1689710399654},{\"identifier\":{\"key\":\"ROOT\",\"namespace\":\"\"},\"name\":\"Open MCT\",\"type\":\"root\",\"composition\":[{\"key\":\"mine\",\"namespace\":\"\"}]}],\"navigationPath\":\"/browse/mine/58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"domainObject\":{\"identifier\":{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"},\"name\":\"Overlay Plot:b0ba67ab-e383-40c1-a181-82b174e8fdf0\",\"type\":\"telemetry.plot.overlay\",\"composition\":[{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"}],\"configuration\":{\"series\":[]},\"notes\":\"framework/generateVisualTestData.e2e.spec.js\\nGenerate Visual Test Data @localStorage\\nchrome\",\"modified\":1689710400435,\"location\":\"mine\",\"created\":1689710399651,\"persisted\":1689710400436}},{\"objectPath\":[{\"identifier\":{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"},\"name\":\"Unnamed Sine Wave Generator\",\"type\":\"generator\",\"telemetry\":{\"period\":10,\"amplitude\":1,\"offset\":0,\"dataRateInHz\":1,\"phase\":0,\"randomness\":0,\"loadDelay\":\"5000\",\"infinityValues\":false,\"staleness\":false},\"modified\":1689710400433,\"location\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"created\":1689710400433,\"persisted\":1689710400433},{\"identifier\":{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"},\"name\":\"Overlay Plot:b0ba67ab-e383-40c1-a181-82b174e8fdf0\",\"type\":\"telemetry.plot.overlay\",\"composition\":[{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"}],\"configuration\":{\"series\":[]},\"notes\":\"framework/generateVisualTestData.e2e.spec.js\\nGenerate Visual Test Data @localStorage\\nchrome\",\"modified\":1689710400435,\"location\":\"mine\",\"created\":1689710399651,\"persisted\":1689710400436},{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"modified\":1689710399654,\"created\":1689710398656,\"persisted\":1689710399654},{\"identifier\":{\"key\":\"ROOT\",\"namespace\":\"\"},\"name\":\"Open MCT\",\"type\":\"root\",\"composition\":[{\"key\":\"mine\",\"namespace\":\"\"}]}],\"navigationPath\":\"/browse/mine/58f55f3a-46d9-4c37-a726-27b5d38b895a/19f2e461-190e-4662-8d62-251e90bb7aac\",\"domainObject\":{\"identifier\":{\"key\":\"19f2e461-190e-4662-8d62-251e90bb7aac\",\"namespace\":\"\"},\"name\":\"Unnamed Sine Wave Generator\",\"type\":\"generator\",\"telemetry\":{\"period\":10,\"amplitude\":1,\"offset\":0,\"dataRateInHz\":1,\"phase\":0,\"randomness\":0,\"loadDelay\":\"5000\",\"infinityValues\":false,\"staleness\":false},\"modified\":1689710400433,\"location\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"created\":1689710400433,\"persisted\":1689710400433}},{\"objectPath\":[{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"modified\":1689710399654,\"created\":1689710398656,\"persisted\":1689710399654},{\"identifier\":{\"key\":\"ROOT\",\"namespace\":\"\"},\"name\":\"Open MCT\",\"type\":\"root\",\"composition\":[{\"key\":\"mine\",\"namespace\":\"\"}]}],\"navigationPath\":\"/browse/mine\",\"domainObject\":{\"identifier\":{\"key\":\"mine\",\"namespace\":\"\"},\"name\":\"My Items\",\"type\":\"folder\",\"composition\":[{\"key\":\"58f55f3a-46d9-4c37-a726-27b5d38b895a\",\"namespace\":\"\"}],\"location\":\"ROOT\",\"modified\":1689710399654,\"created\":1689710398656,\"persisted\":1689710399654}}]"
},
{
"name": "mct-tree-expanded",
"value": "[\"/browse/mine\"]"
"value": "[]"
}
]
}
]
}
}