Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role attribution to notebook entries and export #6793

Merged
merged 2 commits into from Jul 13, 2023
Merged

Conversation

michaelrogers
Copy link
Contributor

@michaelrogers michaelrogers commented Jul 11, 2023

Closes #6664

Dependent on #6706 for openmct.user.getActiveRole.

Describe your changes:

Capture the active role at when an entry is modified and created. Altered the export as text action to include the additional values when available. Fixed a bug where modified username was not being exported only Unknown.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero added the type:feature Feature. Required intentional design label Jul 11, 2023
@deploysentinel
Copy link

deploysentinel bot commented Jul 11, 2023

Current Playwright Test Results Summary

✅ 13 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/13/2023 07:08:33pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 62f53e5

Started: 07/13/2023 07:04:40pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
14.71% (5) 5 / 34 runs
failed over last 7 days
70.59% (24) 24 / 34 runs
flaked over last 7 days

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1Initial Attempt
2.94% (1) 1 / 34 run
failed over last 7 days
11.76% (4) 4 / 34 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 123 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/13/2023 07:08:33pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 62f53e5

Started: 07/13/2023 06:55:31pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
1.72% (2) 2 / 116 runs
failed over last 7 days
77.59% (90) 90 / 116 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@jvigliotta jvigliotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #6793 (62f53e5) into master (ac22beb) will increase coverage by 0.12%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master    #6793      +/-   ##
==========================================
+ Coverage   53.80%   53.93%   +0.12%     
==========================================
  Files         624      624              
  Lines       24898    24907       +9     
  Branches     2498     2499       +1     
==========================================
+ Hits        13397    13434      +37     
+ Misses      10829    10802      -27     
+ Partials      672      671       -1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.18% <ø> (-0.01%) ⬇️ Carriedforward from ac22beb
e2e-stable 55.39% <57.14%> (+0.23%) ⬆️
unit 48.80% <45.45%> (+0.25%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ins/notebook/actions/ExportNotebookAsTextAction.js 50.64% <0.00%> (-1.36%) ⬇️
src/plugins/notebook/components/NotebookEntry.vue 17.32% <0.00%> (-0.42%) ⬇️
src/plugins/notebook/utils/notebook-entries.js 82.17% <100.00%> (+2.79%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac22beb...62f53e5. Read the comment docs.

@jvigliotta jvigliotta added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023
@jvigliotta jvigliotta enabled auto-merge (squash) July 13, 2023 19:01
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 13, 2023
@jvigliotta jvigliotta merged commit 5031010 into master Jul 13, 2023
14 of 15 checks passed
@jvigliotta jvigliotta deleted the mct6664 branch July 13, 2023 19:09
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature. Required intentional design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants