Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress role selection if no roles available #6802

Merged
merged 2 commits into from Jul 14, 2023

Conversation

akhenry
Copy link
Contributor

@akhenry akhenry commented Jul 14, 2023

Closes #6801

Describe your changes:

Checks if any roles are returned by the user provider. If none, then do not prompt the user to select a role.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero enabled auto-merge (squash) July 14, 2023 23:12
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #6802 (90d3ab9) into master (e386036) will decrease coverage by 2.13%.
The diff coverage is 0.00%.

❗ Current head 90d3ab9 differs from pull request most recent head 92566e7. Consider uploading reports for the commit 92566e7 to get more accurate results

@@            Coverage Diff             @@
##           master    #6802      +/-   ##
==========================================
- Coverage   53.73%   51.61%   -2.13%     
==========================================
  Files         631      631              
  Lines       25146    25148       +2     
  Branches     2520     2521       +1     
==========================================
- Hits        13513    12979     -534     
- Misses      10959    11495     +536     
  Partials      674      674              
Flag Coverage Δ *Carryforward flag
e2e-full 42.28% <ø> (ø) Carriedforward from e386036
e2e-stable 39.49% <ø> (-16.13%) ⬇️
unit 48.27% <0.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...plugins/userIndicator/components/UserIndicator.vue 35.89% <0.00%> (-1.95%) ⬇️

... and 101 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e386036...92566e7. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Jul 14, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 11:22:08pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 92566e7

Started: 07/14/2023 11:19:03pm UTC

⚠️ Flakes

📄   functional/forms.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Persistence operations @couchdb Can create an object after a conflict error @couchdb @2p
Retry 1Initial Attempt
7.69% (4) 4 / 52 runs
failed over last 7 days
3.85% (2) 2 / 52 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 133 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/14/2023 11:22:08pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 92566e7

Started: 07/14/2023 11:15:06pm UTC

⚠️ Flakes

📄   functional/plugins/timer/timer.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Timer Can perform actions on the Timer
Retry 1Initial Attempt
0% (0) 0 / 110 runs
failed over last 7 days
0.91% (1) 1 / 110 run
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Plot View of telemetry items
Retry 2Retry 1Initial Attempt
0% (0) 0 / 110 runs
failed over last 7 days
25.45% (28) 28 / 110 runs
flaked over last 7 days

View Detailed Build Results


@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 14, 2023
@unlikelyzero unlikelyzero merged commit 662d143 into master Jul 14, 2023
12 of 13 checks passed
@unlikelyzero unlikelyzero deleted the suppress-role-selection branch July 14, 2023 23:22
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress role selection if no roles available
3 participants