Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default local clock #6807

Merged
merged 8 commits into from
Jul 18, 2023
Merged

Default local clock #6807

merged 8 commits into from
Jul 18, 2023

Conversation

jvigliotta
Copy link
Contributor

Closes

Describe your changes:

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

…t on load, make it so clocks are not started only when they get a listener and not stopped with they have no listeners, start/stop clocks in "setClock" method
@jvigliotta jvigliotta changed the base branch from master to mode-dropdown July 17, 2023 22:16
@deploysentinel
Copy link

deploysentinel bot commented Jul 17, 2023

Current Playwright Test Results Summary

✅ 55 Passing - ❌ 4 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/19/2023 12:05:04am UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 0a37a58

Started: 07/18/2023 11:55:23pm UTC

❌ Failures

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 2Retry 1Initial Attempt
Error: Test timeout of 180000ms exceeded.
Test timeout of 180000ms exceeded.
32.10% (52) 52 / 162 runs
failed over last 7 days
2.47% (4) 4 / 162 runs
flaked over last 7 days

📄   functional/notification.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notification Overlay Closing notification list after notification banner disappeared does not cause it to open automatically
Retry 1Initial Attempt
Error: page.evaluate: Execution context was destroyed, most likely because of a navigat...
page.evaluate: Execution context was destroyed, most likely because of a navigation
27.18% (53) 53 / 195 runs
failed over last 7 days
0% (0) 0 / 195 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 2Retry 1Initial Attempt
Error: expect(received).toEqual(expected) // deep equality...
expect(received).toEqual(expected) // deep equality

Expected: 5
Received: 0
18.93% (32) 32 / 169 runs
failed over last 7 days
0% (0) 0 / 169 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 1Initial Attempt
Error: Test timeout of 60000ms exceeded.
Test timeout of 60000ms exceeded.
100% (18) 18 / 18 runs
failed over last 7 days
0% (0) 0 / 18 runs
flaked over last 7 days

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 180 runs
failed over last 7 days
81.11% (146) 146 / 180 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #6807 (04308da) into mode-dropdown (249f820) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head 04308da differs from pull request most recent head 0a37a58. Consider uploading reports for the commit 0a37a58 to get more accurate results

@@              Coverage Diff               @@
##           mode-dropdown    #6807   +/-   ##
==============================================
  Coverage          45.43%   45.44%           
==============================================
  Files                408      408           
  Lines              12515    12519    +4     
==============================================
+ Hits                5686     5689    +3     
- Misses              6829     6830    +1     
Flag Coverage Δ *Carryforward flag
e2e-full 41.77% <ø> (-0.01%) ⬇️ Carriedforward from 9f95fcf
e2e-stable 39.49% <75.00%> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
src/MCT.js 89.42% <66.66%> (-0.68%) ⬇️
src/plugins/utcTimeSystem/LocalClock.js 80.00% <100.00%> (+1.42%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249f820...0a37a58. Read the comment docs.

src/api/time/IndependentTimeContext.js Outdated Show resolved Hide resolved
src/api/time/TimeContext.js Outdated Show resolved Hide resolved
src/utils/clock/DefaultClock.js Outdated Show resolved Hide resolved
@jvigliotta jvigliotta requested a review from akhenry July 18, 2023 23:37
@akhenry akhenry merged commit 043233f into mode-dropdown Jul 18, 2023
0 of 5 checks passed
@akhenry akhenry deleted the default-local-clock branch July 18, 2023 23:55
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants