Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the current timestamp from the global clock #6851

Merged
merged 3 commits into from Jul 28, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jul 28, 2023

Closes #6797

Describe your changes:

Use the current timestamp from the global clock
Use mode changes to set if the view is fixed time or real time

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jul 28, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/28/2023 04:16:26pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 10f79e0

Started: 07/28/2023 04:14:27pm UTC

⚠️ Flakes

📄   functional/couchdb.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
CouchDB Status Indicator with mocked responses @couchdb Shows red if not connected
Retry 1Initial Attempt
0% (0) 0 / 35 runs
failed over last 7 days
5.71% (2) 2 / 35 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 131 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/28/2023 04:16:26pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 10f79e0

Started: 07/28/2023 03:54:08pm UTC

⚠️ Flakes

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time conductor operations validate start time does not exceeds end time
Retry 1Initial Attempt
0% (0) 0 / 45 runs
failed over last 7 days
2.22% (1) 1 / 45 run
flaked over last 7 days

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
37.74% (20) 20 / 53 runs
failed over last 7 days
15.09% (8) 8 / 53 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #6851 (10f79e0) into master (7c58b19) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6851      +/-   ##
==========================================
- Coverage   48.16%   48.11%   -0.06%     
==========================================
  Files         643      643              
  Lines       25620    25615       -5     
  Branches     2512     2509       -3     
==========================================
- Hits        12341    12325      -16     
- Misses      12802    12815      +13     
+ Partials      477      475       -2     
Flag Coverage Δ *Carryforward flag
e2e-full 41.97% <ø> (ø) Carriedforward from 2a0e546
e2e-stable 56.68% <ø> (+0.37%) ⬆️
unit 38.73% <0.00%> (+0.04%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/timelist/Timelist.vue 3.11% <0.00%> (+0.06%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c58b19...10f79e0. Read the comment docs.

@ozyx ozyx self-requested a review July 28, 2023 16:11
@ozyx ozyx added this to the Target:3.0.0 milestone Jul 28, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 28, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozyx ozyx merged commit d4e51cb into master Jul 28, 2023
14 checks passed
@ozyx ozyx deleted the timelist-use-now-timestamp branch July 28, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time list view should use the global clock in fixed time mode
2 participants