Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow editing line more when not editing display layout #6858

Merged
merged 2 commits into from Jul 31, 2023

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented Jul 31, 2023

Closes #6846

Describe your changes:

Check if we're in edit mode before showing frame edit for line view

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Jul 31, 2023

Current Playwright Test Results Summary

✅ 131 Passing - ⚠️ 4 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/31/2023 05:16:36pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 9cbce3c

Started: 07/31/2023 05:10:42pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 2Retry 1Initial Attempt
8.64% (7) 7 / 81 runs
failed over last 7 days
33.33% (27) 27 / 81 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
1.47% (1) 1 / 68 run
failed over last 7 days
17.65% (12) 12 / 68 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use independent time conductor to change time
Retry 1Initial Attempt
17.33% (13) 13 / 75 runs
failed over last 7 days
14.67% (11) 11 / 75 runs
flaked over last 7 days

📄   functional/plugins/plot/autoscale.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Autoscale User can set autoscale with a valid range @snapshot
Retry 2Retry 1Initial Attempt
28% (21) 21 / 75 runs
failed over last 7 days
17.33% (13) 13 / 75 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 07/31/2023 05:16:36pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 9cbce3c

Started: 07/31/2023 05:03:56pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1Initial Attempt
6.67% (3) 3 / 45 runs
failed over last 7 days
20% (9) 9 / 45 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #6858 (fcd9024) into master (3ae14cf) will decrease coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head fcd9024 differs from pull request most recent head 9cbce3c. Consider uploading reports for the commit 9cbce3c to get more accurate results

@@            Coverage Diff             @@
##           master    #6858      +/-   ##
==========================================
- Coverage   48.29%   48.18%   -0.12%     
==========================================
  Files         643      643              
  Lines       25619    25619              
  Branches     2507     2507              
==========================================
- Hits        12373    12344      -29     
- Misses      12757    12799      +42     
+ Partials      489      476      -13     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (ø) Carriedforward from 3ae14cf
e2e-stable 56.21% <ø> (+1.16%) ⬆️
unit 38.72% <0.00%> (-0.82%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/plugins/displayLayout/components/LineView.vue 22.01% <0.00%> (ø)

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ef93d...9cbce3c. Read the comment docs.

@ozyx ozyx self-requested a review July 31, 2023 16:58
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and with VIPER testing environment-- works well! Nice fix.

@ozyx ozyx enabled auto-merge (squash) July 31, 2023 16:59
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 31, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jul 31, 2023
@ozyx ozyx merged commit 50559ac into master Jul 31, 2023
12 of 13 checks passed
@ozyx ozyx deleted the fix-line-view-edit branch July 31, 2023 17:16
@scottbell scottbell mentioned this pull request Aug 9, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Display Layout] Lines can be edited when not in edit mode.
2 participants