Synchronize timers between multiple users #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eshing the timer domain object
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 08/02/2023 11:20:26pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: 6358b9c Started: 08/02/2023 11:17:36pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 1 • Initial Attempt |
9.84% (6)6 / 61 runsfailed over last 7 days |
19.67% (12)12 / 61 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 131 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 08/02/2023 11:20:26pm UTC)
⚠️ Flakes
📄 functional/planning/timelist.e2e.spec.js • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1 • Initial Attempt |
2.16% (3)3 / 139 runsfailed over last 7 days |
21.58% (30)30 / 139 runsflaked over last 7 days |
Codecov Report
@@ Coverage Diff @@
## master #6885 +/- ##
==========================================
- Coverage 48.27% 48.25% -0.03%
==========================================
Files 643 644 +1
Lines 25629 25636 +7
Branches 2505 2499 -6
==========================================
- Hits 12373 12371 -2
- Misses 12783 12789 +6
- Partials 473 476 +3
*This pull request uses carry forward flags. Click here to find out more.
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ozyx
approved these changes
Aug 2, 2023
15 tasks
ozyx
added a commit
that referenced
this pull request
Aug 2, 2023
* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object * Simplify timer logic * Clarify code a little * refactor: lint:fix * Fix linting issue --------- Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov> Co-authored-by: Jesse Mazzella <jesse.d.mazzella@nasa.gov> Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
shefalijoshi
pushed a commit
that referenced
this pull request
Aug 2, 2023
* created a throttle util and using it in timer plugin to throttle refreshing the timer domain object * Simplify timer logic * Clarify code a little * refactor: lint:fix * Fix linting issue --------- Co-authored-by: Andrew Henry <akhenry@gmail.com> Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6880
Describe your changes:
Thanks to @jvigliotta and @ozyx for doing most of the work here, allowing me to swoop in and claim the credit.
*listener. This is gross, but I think we were hitting an issue with properties on proxied objects being replaced with non-proxied versions when a refresh happensAll Submissions:
Author Checklist
Reviewer Checklist