Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Playwright to 1.36.2 #6901

Merged
merged 6 commits into from Aug 8, 2023
Merged

chore: bump Playwright to 1.36.2 #6901

merged 6 commits into from Aug 8, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Aug 7, 2023

Describe your changes:

Version bump

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from unlikelyzero August 7, 2023 23:25
@deploysentinel
Copy link

deploysentinel bot commented Aug 7, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 05:42:34pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 78ec5e4

Started: 08/08/2023 05:36:49pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/08/2023 05:42:34pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 78ec5e4

Started: 08/08/2023 05:35:48pm UTC

⚠️ Flakes

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
0% (0) 0 / 83 runs
failed over last 7 days
25.30% (21) 21 / 83 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 119 runs
failed over last 7 days
35.29% (42) 42 / 119 runs
flaked over last 7 days

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery Object Can use Mouse Wheel to zoom in and out of latest image
Retry 1Initial Attempt
0% (0) 0 / 89 runs
failed over last 7 days
4.49% (4) 4 / 89 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #6901 (27fb795) into master (6a9ff91) will decrease coverage by 4.31%.
The diff coverage is n/a.

❗ Current head 27fb795 differs from pull request most recent head 78ec5e4. Consider uploading reports for the commit 78ec5e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #6901      +/-   ##
==========================================
- Coverage   48.35%   44.05%   -4.31%     
==========================================
  Files         643      643              
  Lines       25627    25627              
  Branches     2496     2496              
==========================================
- Hits        12392    11290    -1102     
- Misses      12761    13860    +1099     
- Partials      474      477       +3     
Flag Coverage Δ *Carryforward flag
e2e-full 42.09% <ø> (+0.06%) ⬆️ Carriedforward from 7321501
e2e-stable ?
unit 38.74% <ø> (-0.05%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 144 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9ff91...78ec5e4. Read the comment docs.

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 7, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 8, 2023
@ozyx ozyx merged commit 1e3097f into master Aug 8, 2023
13 of 15 checks passed
@ozyx ozyx deleted the bump-playwright-1.36.2 branch August 8, 2023 17:44
ozyx added a commit that referenced this pull request Sep 12, 2023
* chore: bump Playwright to `1.36.2`

* chore: remove `playwright/core` dependency

* chore: temporarily disable cacheing step

* chore: temp disable cacheing for e2e-couchdb run

* chore: restore cacheing step

* chore: remove `--prefer-offline` option
unlikelyzero pushed a commit that referenced this pull request Sep 12, 2023
* chore: bump Playwright to `1.36.2`

* chore: remove `playwright/core` dependency

* chore: temporarily disable cacheing step

* chore: temp disable cacheing for e2e-couchdb run

* chore: restore cacheing step

* chore: remove `--prefer-offline` option
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants