Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: modify cspell config and fix all typos #6908

Merged
merged 5 commits into from Aug 10, 2023
Merged

chore: modify cspell config and fix all typos #6908

merged 5 commits into from Aug 10, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Aug 9, 2023

No related issue

Describe your changes:

Modifies the cspell config to add more dictionaries and remove typos from accepted-words list. Modifies the lint:spelling command to include context and only lint *.js, *.vue, and *.md files. Fixes all typos identified by cspell.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from unlikelyzero August 9, 2023 18:09
@deploysentinel
Copy link

deploysentinel bot commented Aug 9, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/10/2023 04:19:57pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 8ddcc73

Started: 08/10/2023 04:17:47pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 6 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/10/2023 04:19:57pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 8ddcc73

Started: 08/10/2023 01:23:26am UTC

⚠️ Flakes

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
0% (0) 0 / 81 runs
failed over last 7 days
23.46% (19) 19 / 81 runs
flaked over last 7 days

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
0% (0) 0 / 84 runs
failed over last 7 days
20.24% (17) 17 / 84 runs
flaked over last 7 days

📄   functional/plugins/plot/tagging.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Plot Tagging Tags work with Overlay Plots
Retry 1Initial Attempt
10.26% (8) 8 / 78 runs
failed over last 7 days
24.36% (19) 19 / 78 runs
flaked over last 7 days

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
13.21% (14) 14 / 106 runs
failed over last 7 days
29.25% (31) 31 / 106 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 115 runs
failed over last 7 days
42.61% (49) 49 / 115 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
1.19% (1) 1 / 84 run
failed over last 7 days
32.14% (27) 27 / 84 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #6908 (8ddcc73) into master (9be9c5e) will increase coverage by 0.00%.
The diff coverage is 53.84%.

@@           Coverage Diff           @@
##           master    #6908   +/-   ##
=======================================
  Coverage   48.38%   48.39%           
=======================================
  Files         643      643           
  Lines       25627    25627           
  Branches     2496     2496           
=======================================
+ Hits        12399    12401    +2     
- Misses      12739    12749   +10     
+ Partials      489      477   -12     
Flag Coverage Δ *Carryforward flag
e2e-full 42.04% <ø> (+<0.01%) ⬆️ Carriedforward from 71775e1
e2e-stable 57.22% <50.00%> (+4.00%) ⬆️
unit 38.74% <38.46%> (-0.82%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/api/forms/FormsAPI.js 94.87% <ø> (ø)
src/api/objects/ObjectAPI.js 93.08% <ø> (ø)
src/api/telemetry/TelemetryAPI.js 89.90% <ø> (+0.96%) ⬆️
src/api/telemetry/TelemetryMetadataManager.js 78.94% <ø> (ø)
src/api/types/Type.js 7.89% <ø> (ø)
src/api/user/UserAPI.js 91.42% <ø> (ø)
src/plugins/LADTable/components/LADRow.vue 53.40% <ø> (ø)
src/plugins/charts/bar/BarGraphView.vue 45.88% <0.00%> (ø)
src/plugins/charts/scatter/ScatterPlotView.vue 0.00% <ø> (ø)
...ugins/faultManagement/FaultManagementInspector.vue 0.00% <0.00%> (ø)
... and 28 more

... and 36 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be9c5e...8ddcc73. Read the comment docs.

Copy link
Collaborator

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@ozyx ozyx enabled auto-merge (squash) August 10, 2023 01:21
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 10, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 10, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 10, 2023
@ozyx ozyx merged commit 10f3e13 into master Aug 10, 2023
13 of 15 checks passed
@ozyx ozyx deleted the cspell-modify branch August 10, 2023 16:20
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants