Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couchdb setup and add a note on how to remove the container #6915

Merged
merged 5 commits into from Aug 22, 2023

Conversation

unlikelyzero
Copy link
Collaborator

@unlikelyzero unlikelyzero commented Aug 10, 2023

Closes #6914

Describe your changes:

Updates the init script to break out the users and replication db into discrete steps

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 10, 2023
@deploysentinel
Copy link

deploysentinel bot commented Aug 10, 2023

Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/22/2023 04:57:36pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 9992e59

Started: 08/22/2023 04:52:12pm UTC

View Detailed Build Results


Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/22/2023 04:57:36pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 9992e59

Started: 08/22/2023 04:50:55pm UTC

⚠️ Flakes

📄   functional/plugins/imagery/exampleImagery.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Example Imagery in Display Layout Toggle layer visibility by clicking on label
Retry 2Retry 1Initial Attempt
0% (0) 0 / 139 runs
failed over last 7 days
5.04% (7) 7 / 139 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 170 runs
failed over last 7 days
55.88% (95) 95 / 170 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit
Retry 1Initial Attempt
0% (0) 0 / 138 runs
failed over last 7 days
38.41% (53) 53 / 138 runs
flaked over last 7 days

View Detailed Build Results


@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #6915 (b891ddc) into master (351800b) will decrease coverage by 6.33%.
The diff coverage is n/a.

❗ Current head b891ddc differs from pull request most recent head 9992e59. Consider uploading reports for the commit 9992e59 to get more accurate results

@@            Coverage Diff             @@
##           master    #6915      +/-   ##
==========================================
- Coverage   48.32%   42.00%   -6.33%     
==========================================
  Files         643      410     -233     
  Lines       25721    12701   -13020     
  Branches     2512        0    -2512     
==========================================
- Hits        12430     5335    -7095     
+ Misses      12809     7366    -5443     
+ Partials      482        0     -482     
Flag Coverage Δ
e2e-full 42.00% <ø> (+0.01%) ⬆️
e2e-stable ?
unit ?

see 508 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351800b...9992e59. Read the comment docs.

ozyx
ozyx previously requested changes Aug 10, 2023
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small comments re: print statements

src/plugins/persistence/couch/setup-couchdb.sh Outdated Show resolved Hide resolved
src/plugins/persistence/couch/setup-couchdb.sh Outdated Show resolved Hide resolved
@unlikelyzero
Copy link
Collaborator Author

@ozyx resolved

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 11, 2023
@unlikelyzero unlikelyzero requested a review from ozyx August 11, 2023 21:51
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 11, 2023
@shefalijoshi
Copy link
Contributor

@johnhill2 Please add testing instructions

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@unlikelyzero unlikelyzero enabled auto-merge (squash) August 21, 2023 19:44
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 22, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 22, 2023
@unlikelyzero unlikelyzero removed the request for review from ozyx August 22, 2023 18:10
@unlikelyzero unlikelyzero merged commit 42b13c4 into master Aug 22, 2023
15 of 16 checks passed
@unlikelyzero unlikelyzero deleted the fix-couchdb branch August 22, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CouchDB] init script is missing the create_users_db() step and creating lots of errors
3 participants