Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): minor fixes from validation #6962

Merged
merged 3 commits into from Aug 21, 2023
Merged

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 18, 2023

Closes #6965

Describe your changes:

Fixes some html issues in the index.html file

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 18, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 04:27:00pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: e84a309

Started: 08/21/2023 04:20:36pm UTC

⚠️ Flakes

📄   functional/plugins/telemetryTable/telemetryTable.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Telemetry Table unpauses and filters data when paused by button and user changes bounds
Retry 1Initial Attempt
4.29% (6) 6 / 140 runs
failed over last 7 days
15.71% (22) 22 / 140 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 176 runs
failed over last 7 days
52.27% (92) 92 / 176 runs
flaked over last 7 days

View Detailed Build Results


@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #6962 (e84a309) into master (a52577e) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6962      +/-   ##
==========================================
- Coverage   48.66%   48.31%   -0.35%     
==========================================
  Files         643      643              
  Lines       25719    25719              
  Branches     2512     2512              
==========================================
- Hits        12517    12427      -90     
- Misses      12699    12810     +111     
+ Partials      503      482      -21     
Flag Coverage Δ *Carryforward flag
e2e-full 42.00% <ø> (ø) Carriedforward from a52577e
e2e-stable 57.24% <ø> (+0.08%) ⬆️
unit 38.67% <ø> (-0.65%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52577e...e84a309. Read the comment docs.

Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Two things:

  1. Let's link this to an issue. Either one in the backlog or let's create a new one describing the work (for traceability).
  2. The official title is "Open MCT" (2 words). I left a suggestion in the review.

Thanks for this! It should be good to merge once those two issues are addressed.

index.html Outdated Show resolved Hide resolved
@ozyx ozyx added the source:community Community contribution or request label Aug 18, 2023
Co-authored-by: Jesse Mazzella <ozyx@users.noreply.github.com>
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ozyx ozyx added this to the Target:3.1.0 milestone Aug 21, 2023
@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@ozyx ozyx merged commit 0a49748 into nasa:master Aug 21, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONVENTION]: Validate index.html file
2 participants