Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): add fields #6971

Merged
merged 2 commits into from Aug 21, 2023

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Aug 20, 2023

Closes #6974

Describe your changes:

Makes pkg json better

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@deploysentinel
Copy link

deploysentinel bot commented Aug 20, 2023

Current Playwright Test Results Summary

✅ 136 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/21/2023 08:31:53pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 7c4d773

Started: 08/21/2023 08:26:11pm UTC

View Detailed Build Results


@ozyx ozyx added the source:community Community contribution or request label Aug 20, 2023
@evenstensberg
Copy link
Contributor Author

Cumulus team has a linter for package.json, I don't think that's necessary for us, since it won't change much:

https://github.com/nasa/cumulus/blob/master/npmpackagejsonlint.config.js

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@unlikelyzero unlikelyzero removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #6971 (1576e1b) into master (0a49748) will decrease coverage by 6.26%.
The diff coverage is n/a.

❗ Current head 1576e1b differs from pull request most recent head 7c4d773. Consider uploading reports for the commit 7c4d773 to get more accurate results

@@            Coverage Diff             @@
##           master    #6971      +/-   ##
==========================================
- Coverage   48.26%   42.00%   -6.26%     
==========================================
  Files         643      410     -233     
  Lines       25719    12701   -13018     
  Branches     2512        0    -2512     
==========================================
- Hits        12413     5335    -7078     
+ Misses      12824     7366    -5458     
+ Partials      482        0     -482     
Flag Coverage Δ
e2e-full 42.00% <ø> (ø)
e2e-stable ?
unit ?

see 507 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a49748...7c4d773. Read the comment docs.

@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 21, 2023
@unlikelyzero unlikelyzero enabled auto-merge (squash) August 21, 2023 17:59
@unlikelyzero unlikelyzero merged commit 9ece4e5 into nasa:master Aug 21, 2023
14 of 15 checks passed
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:e2e:couchdb npm run test:e2e:couchdb source:community Community contribution or request type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INFRA]: Improve package.json fields more
4 participants