Imagery layer checkbox should match layer visiblity

[shefalijoshi]

Closes #6266 #6992

Describe your changes:

Set layer visibility to false if layer visibility cannot be persisted

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

• Changes appear to address issue?
• Reviewer has tested changes by following the provided instructions?
• Changes appear not to be breaking changes?
• Appropriate automated tests included?
• Code style and in-line documentation are appropriate?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[deploysentinel]

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 05:28:44pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 2e84b24

Started: 08/28/2023 05:22:25pm UTC

⚠️ Flakes

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb Retry 1 • Initial Attempt	17.86% (5) 5 / 28 runs failed over last 7 days	25% (7) 7 / 28 runs flaked over last 7 days

---

View Detailed Build Results

---

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 05:28:44pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 2e84b24

Started: 08/28/2023 05:22:00pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 2 Flakes

Top 1 Common Error Messages

null	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Allows embeds to be deleted if page unlocked @addinit Retry 1 • Initial Attempt	3.57% (2) 2 / 56 runs failed over last 7 days	41.07% (23) 23 / 56 runs flaked over last 7 days
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit Retry 1 • Initial Attempt	0% (0) 0 / 54 runs failed over last 7 days	38.89% (21) 21 / 54 runs flaked over last 7 days

---

📄   functional/plugins/timeConductor/timeConductor.e2e.spec.js • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Time conductor operations validate start time does not exceeds end time Retry 1 • Initial Attempt	0% (0) 0 / 53 runs failed over last 7 days	3.77% (2) 2 / 53 runs flaked over last 7 days

---

View Detailed Build Results

---

[ozyx]

Seems to work well! Nice fix

[scottbell]

Tested with core on an immutable object and it seemed to work:

Screen.Recording.2023-08-28.at.7.34.37.PM.mov