Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update staticRootPlugin README #7014

Merged
merged 1 commit into from Aug 29, 2023
Merged

docs: update staticRootPlugin README #7014

merged 1 commit into from Aug 29, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Aug 29, 2023

Closes #7005

Describe your changes:

Updates the StaticRootPlugin README to be accurate

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@ozyx ozyx requested a review from scottbell August 29, 2023 20:25
@deploysentinel
Copy link

deploysentinel bot commented Aug 29, 2023

Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/29/2023 08:59:53pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: 4a7f4d8

Started: 08/29/2023 08:53:08pm UTC

⚠️ Flakes

📄   functional/plugins/plot/logPlot.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Log plot tests Log Plot ticks are functionally correct in regular and log mode and after refresh
Retry 1Initial Attempt
1.54% (1) 1 / 65 run
failed over last 7 days
27.69% (18) 18 / 65 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 61 runs
failed over last 7 days
44.26% (27) 27 / 61 runs
flaked over last 7 days

📄   functional/planning/timelist.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Time List Create a Time List, add a single Plan to it and verify all the activities are displayed with no milliseconds
Retry 1Initial Attempt
0% (0) 0 / 94 runs
failed over last 7 days
52.13% (49) 49 / 94 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/29/2023 08:59:53pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: 4a7f4d8

Started: 08/29/2023 08:28:29pm UTC

View Detailed Build Results


Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scottbell scottbell merged commit ca06a6a into master Aug 29, 2023
13 of 14 checks passed
@scottbell scottbell deleted the mct7005 branch August 29, 2023 21:09
@shefalijoshi shefalijoshi added the type:maintenance tests, chores, or project maintenance label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Static Root README
3 participants