Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#7022): remove ProgressBar artifacts from Notifications #7024

Merged
merged 3 commits into from Sep 4, 2023

Conversation

ozyx
Copy link
Member

@ozyx ozyx commented Aug 31, 2023

Closes #7022

Describe your changes:

A refactor to use null instead of undefined for ProgressBars caused some checks to fail. Fixed by checking for truthiness in general instead of checking against null specifically.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #7024 (d659af2) into master (e9b94c3) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
- Coverage   48.33%   48.27%   -0.06%     
==========================================
  Files         643      643              
  Lines       25730    25744      +14     
  Branches     2512     2512              
==========================================
- Hits        12436    12428       -8     
- Misses      12813    12834      +21     
- Partials      481      482       +1     
Flag Coverage Δ *Carryforward flag
e2e-full 42.02% <ø> (-0.03%) ⬇️ Carriedforward from 82033b0
e2e-stable 57.15% <ø> (-0.10%) ⬇️
unit 38.65% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
src/ui/components/ProgressBar.vue 100.00% <ø> (ø)
src/ui/layout/status-bar/NotificationBanner.vue 44.82% <ø> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b94c3...d659af2. Read the comment docs.

@deploysentinel
Copy link

deploysentinel bot commented Aug 31, 2023

Current Playwright Test Results Summary

✅ 14 Passing - ⚠️ 2 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/04/2023 12:51:03pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: d659af2

Started: 09/04/2023 12:47:46pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/notebookWithCouchDB.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1Initial Attempt
0% (0) 0 / 38 runs
failed over last 7 days
10.53% (4) 4 / 38 runs
flaked over last 7 days

📄   functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2Retry 1Initial Attempt
10.53% (4) 4 / 38 runs
failed over last 7 days
18.42% (7) 7 / 38 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 136 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 09/04/2023 12:51:03pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: d659af2

Started: 09/04/2023 12:42:18pm UTC

⚠️ Flakes

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 104 runs
failed over last 7 days
55.77% (58) 58 / 104 runs
flaked over last 7 days

View Detailed Build Results


@ozyx ozyx requested a review from scottbell September 1, 2023 20:31
Copy link
Contributor

@scottbell scottbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! LGTM:

Screen.Recording.2023-09-04.at.2.42.24.PM.mov

@scottbell scottbell enabled auto-merge (squash) September 4, 2023 12:43
@scottbell scottbell added the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Sep 4, 2023
@scottbell scottbell merged commit 9f7b3b9 into master Sep 4, 2023
15 of 23 checks passed
@scottbell scottbell deleted the mct7022 branch September 4, 2023 12:51
@unlikelyzero unlikelyzero added this to the Target:3.3.0 milestone Feb 27, 2024
@unlikelyzero unlikelyzero modified the milestones: Target:3.3.0, Target:4.0.0 Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications have ProgressBar artifacts in them
3 participants