New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#7022): remove ProgressBar artifacts from Notifications #7024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7024 +/- ##
==========================================
- Coverage 48.33% 48.27% -0.06%
==========================================
Files 643 643
Lines 25730 25744 +14
Branches 2512 2512
==========================================
- Hits 12436 12428 -8
- Misses 12813 12834 +21
- Partials 481 482 +1
*This pull request uses carry forward flags. Click here to find out more.
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Current Playwright Test Results Summary✅ 14 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 09/04/2023 12:51:03pm UTC) Run DetailsRunning Workflow e2e-couchdb on Github Actions Commit: d659af2 Started: 09/04/2023 12:47:46pm UTC
|
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Notebook Tests with CouchDB @couchdb Inspect Notebook Entry Network Requests
Retry 1 • Initial Attempt |
0% (0)0 / 38 runsfailed over last 7 days |
10.53% (4)4 / 38 runsflaked over last 7 days |
📄 functional/plugins/displayLayout/displayLayout.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Display Layout When multiple plots are contained in a layout, we only ask for annotations once @couchdb
Retry 2 • Retry 1 • Initial Attempt |
10.53% (4)4 / 38 runsfailed over last 7 days |
18.42% (7)7 / 38 runsflaked over last 7 days |
Current Playwright Test Results Summary
✅ 136 Passing -
Run may still be in progress, this comment will be updated as current testing workflow or job completes...
(Last updated on 09/04/2023 12:51:03pm UTC)
⚠️ Flakes
📄 functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake
Test Case Results
Test Case | Last 7 days Failures | Last 7 days Flakes |
---|---|---|
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1 • Initial Attempt |
0% (0)0 / 104 runsfailed over last 7 days |
55.77% (58)58 / 104 runsflaked over last 7 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! LGTM:
Closes #7022
Describe your changes:
A refactor to use
null
instead ofundefined
for ProgressBars caused some checks to fail. Fixed by checking for truthiness in general instead of checking againstnull
specifically.All Submissions:
Author Checklist
Reviewer Checklist